Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed pre-commit formatter from Black to Ruff #1149

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SuibhneOFoighil
Copy link

@SuibhneOFoighil SuibhneOFoighil commented Mar 28, 2024

Describe the changes you have made:

Added Ruff, changed pre-commit script and relevant docs (contributing.md)

Reference any relevant issues (e.g. "Fixes #000"):

Fixes "Change formatter from Black to Ruff #849"

Pre-Submission Checklist (optional but appreciated):

  • [ x] I have included relevant documentation updates (stored in /docs)
  • [ x] I have read docs/CONTRIBUTING.md
  • I have read docs/ROADMAP.md

OS Tests (optional but appreciated):

  • Tested on Windows
  • Tested on MacOS
  • Tested on Linux

@SuibhneOFoighil
Copy link
Author

LMK if I can do anything to improve it!

@dheavy
Copy link
Contributor

dheavy commented Mar 31, 2024

@SuibhneOFoighil, I'll test on Windows for you!
Edit: it works on Windows, you can tick that box too!

Comment on lines +53 to -59
ruff = "^0.3.4"

[tool.poetry.extras]
os = ["opencv-python", "pyautogui", "plyer", "pywinctl", "pytesseract", "sentence-transformers", "ipywidgets", "torch", "timm"]
safe = ["semgrep", "yaspin"]

[tool.poetry.group.dev.dependencies]
black = "^23.10.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move ruff to dev.dependencies

@KillianLucas
Copy link
Collaborator

Hi @SuibhneOFoighil, thanks for tackling this and thanks @Notnaton and @dheavy for testing! As Anton said I think it would be smart to move it to dev dependencies, then will merge. Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants