Access control & audit improvements - #552
Merged
OxDev-max merged 5 commits intoJul 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses four critical security and compliance gaps in the access control and audit logging systems:
Changes
#494 — Multisig validation gaps
validate_grant_role_target()andvalidate_transfer_admin_target()helpers#493 — Enumerable role registry
DataKey::RoleMembers(Role) -> Vec<Address>storage keyget_role_members(role, page, page_size) -> Vec<Address>paginated view#491 — Audit entry payload
details: Bytesfield to AdminAuditEntry for serialized action metadata#492 — Multisig recovery mechanism
RecoveryProposalstruct and recovery proposal DataKeyspropose_signer_recovery()— Any signer can initiateobject_signer_recovery()— Signers can prevent executionexecute_signer_recovery()— Executes after 30-day timelock with no objectionsTest Coverage
✅ All existing tests continue to pass
✅ New tests for multisig validation parity
✅ New tests for role registry pagination and consistency
✅ New tests for audit entry payloads
✅ New tests for recovery mechanism lifecycle
Notes
Closes #494, Closes #493, Closes #491, Closes #492