Skip to content

On Windows use Polars LTS CPU #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

On Windows use Polars LTS CPU #56

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8ff702f
add switch for polars lts
t0mdavid-m Sep 29, 2025
0fa46dc
autoaccept in CI
t0mdavid-m Sep 29, 2025
d243d14
[temp] remove new window launch
t0mdavid-m Sep 29, 2025
c3471ae
fix command line
t0mdavid-m Sep 29, 2025
f07c301
Revert "[temp] remove new window launch"
t0mdavid-m Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/build-windows-executable-app.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,10 @@ jobs:
sed -i 's/#import site/import site/' python-${{ env.PYTHON_VERSION }}/python311._pth

- name: Install Required Packages
run: .\python-${{ env.PYTHON_VERSION }}\python -m pip install --force-reinstall -r requirements.txt --no-warn-script-location
run: |
.\python-${{ env.PYTHON_VERSION }}\python -m pip install --force-reinstall -r requirements.txt --no-warn-script-location
.\python-${{ env.PYTHON_VERSION }}\python -m pip uninstall polars
.\python-${{ env.PYTHON_VERSION }}\python -m pip install 'polars-lts-cpu >= 1.0'

Comment on lines 277 to 281
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

CI will hang on interactive uninstall; tighten install command.

  • pip uninstall prompts in CI; add -y (or --yes).
  • Use a canonical spec without spaces: "polars-lts-cpu>=1.0".
  • Consider forcing upgrade and verifying env with pip check.

Apply:

-        .\python-${{ env.PYTHON_VERSION }}\python -m pip install --force-reinstall -r requirements.txt --no-warn-script-location
-        .\python-${{ env.PYTHON_VERSION }}\python -m pip uninstall polars
-        .\python-${{ env.PYTHON_VERSION }}\python -m pip install 'polars-lts-cpu >= 1.0'
+        .\python-${{ env.PYTHON_VERSION }}\python -m pip install --force-reinstall -r requirements.txt --no-warn-script-location
+        .\python-${{ env.PYTHON_VERSION }}\python -m pip uninstall -y polars
+        .\python-${{ env.PYTHON_VERSION }}\python -m pip install --upgrade --force-reinstall "polars-lts-cpu>=1.0"
+        .\python-${{ env.PYTHON_VERSION }}\python -m pip check
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
run: |
.\python-${{ env.PYTHON_VERSION }}\python -m pip install --force-reinstall -r requirements.txt --no-warn-script-location
.\python-${{ env.PYTHON_VERSION }}\python -m pip uninstall polars
.\python-${{ env.PYTHON_VERSION }}\python -m pip install 'polars-lts-cpu >= 1.0'
run: |
.\python-${{ env.PYTHON_VERSION }}\python -m pip install --force-reinstall -r requirements.txt --no-warn-script-location
.\python-${{ env.PYTHON_VERSION }}\python -m pip uninstall -y polars
.\python-${{ env.PYTHON_VERSION }}\python -m pip install --upgrade --force-reinstall "polars-lts-cpu>=1.0"
.\python-${{ env.PYTHON_VERSION }}\python -m pip check
🤖 Prompt for AI Agents 
.github/workflows/build-windows-executable-app.yaml around lines 277 to 281: the
pip uninstall will hang waiting for confirmation and the polars spec has an
extra space; change the uninstall command to be non-interactive (add -y or
--yes), replace the package spec with a canonical form without spaces
("polars-lts-cpu>=1.0"), and tighten the install to force an upgrade/consistent
install (e.g., add --upgrade or --force-reinstall) and then run a pip check to
verify the environment.

- name: Set to offline deployment
run: |
Expand Down