-
Notifications
You must be signed in to change notification settings - Fork 0
Add TicChromaogram #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
WalkthroughIntroduces a TIC Chromatogram feature across parsing and rendering: computes per-scan TIC from MS1/MS2 heatmaps, exposes a new component and routing, and wires data into the renderer. Additionally switches some Polars collect() calls to collect(streaming=True) in parsing and compression. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant UI as UI / Layout Manager
participant Init as Renderer Initialize
participant DS as Dataset Store
participant Comp as Chromatogram Component
User->>UI: Select "TIC Chromatogram"
UI->>Init: Request component init (tic_chromatogram)
Note over DS: Parsing step (earlier):<br/>Compute TIC by grouping MS1/MS2 heatmaps<br/>per scan_idx and summing intensity
Init->>DS: Fetch 'tic' data
DS-->>Init: TIC table (scan_idx, rt, level, tic)
Init->>Comp: Instantiate Chromatogram(title='TIC')
Init-->>UI: component_arguments + data_to_send['tic']
UI-->>User: Render TIC Chromatogram
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
🧰 Additional context used🧬 Code graph analysis (2)src/render/initialize.py (2)
src/parse/deconv.py (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit
New Features
Performance
Chores