Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes coupon-code usage with today start/end date #4456

Merged
merged 5 commits into from
Mar 5, 2025

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jan 6, 2025

Description (*)

When both - start and end date - for a coupon-code is today, save end date with "23:59:59" (instead of 00:00:00).

Related Pull Requests

Fixed Issues (if relevant)

@sreichel sreichel added enhancement Component: SalesRule Relates to Mage_SalesRule labels Jan 6, 2025
@sreichel sreichel added this to the 20.13.0 milestone Jan 18, 2025
@sreichel sreichel modified the milestones: 20.13.0, 20.14.0 Feb 18, 2025
@sreichel sreichel requested review from kiatng, addison74 and Hanmac March 5, 2025 18:33
@sreichel
Copy link
Contributor Author

sreichel commented Mar 5, 2025

Hope it's okay to merge this one. Checked again ...

@sreichel sreichel merged commit 643a8ab into OpenMage:main Mar 5, 2025
18 checks passed
@sreichel sreichel deleted the fix-4401 branch March 5, 2025 22:28
fballiano added a commit to MahoCommerce/maho that referenced this pull request Mar 5, 2025
@sreichel sreichel added bug and removed enhancement labels Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Component: SalesRule Relates to Mage_SalesRule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coupon not valid when cart promo rule end date is today.
3 participants