Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed null deprecation in Mage_Eav_Model_Attribute_Data_Text #4500

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Fixed null deprecation in Mage_Eav_Model_Attribute_Data_Text #4500

merged 2 commits into from
Jan 22, 2025

Conversation

kiatng
Copy link
Contributor

@kiatng kiatng commented Jan 21, 2025

Description (*)

    [type] => 8192:E_DEPRECATED
    [message] => trim(): Passing null to parameter #1 ($string) of type string is deprecated
    [file] => .../app/code/core/Mage/Eav/Model/Attribute/Data/Text.php
    [line] => 62
    [uri] => /checkout/onepage/saveBilling/

@kiatng kiatng added the PHP 8 Related to PHP8 label Jan 21, 2025
@github-actions github-actions bot added the Component: Eav Relates to Mage_Eav label Jan 21, 2025
@sreichel sreichel added the bug label Jan 21, 2025
@sreichel sreichel mentioned this pull request Jan 21, 2025
Open
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sreichel sreichel added this to the 20.13.0 milestone Jan 21, 2025
@kiatng kiatng merged commit 00de7b5 into OpenMage:main Jan 22, 2025
17 checks passed
@kiatng kiatng deleted the nd_eav_attribute_data_text branch January 22, 2025 03:37
fballiano added a commit to MahoCommerce/maho that referenced this pull request Jan 22, 2025
@fballiano
OM PR 4500
a0fa939 
OpenMage/magento-lts#4500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

@sreichel sreichel sreichel approved these changes

Assignees
No one assigned
Labels
bug Component: Eav Relates to Mage_Eav PHP 8 Related to PHP8
Projects
None yet
Milestone
20.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kiatng @sreichel @addison74