DRAFT: Fix/environment loader

app/code/core/Mage/Adminhtml/Block/System/Config/Form.php

@@ -25,6 +25,7 @@ class Mage_Adminhtml_Block_System_Config_Form extends Mage_Adminhtml_Block_Widge
     public const SCOPE_DEFAULT = 'default';
     public const SCOPE_WEBSITES = 'websites';
     public const SCOPE_STORES   = 'stores';
+    public const SCOPE_ENV   = 'env';
 
     /**
      * Config data array
@@ -79,6 +80,7 @@ public function __construct()
             self::SCOPE_DEFAULT  => Mage::helper('adminhtml')->__('[GLOBAL]'),
             self::SCOPE_WEBSITES => Mage::helper('adminhtml')->__('[WEBSITE]'),
             self::SCOPE_STORES   => Mage::helper('adminhtml')->__('[STORE VIEW]'),
+            self::SCOPE_ENV      => Mage::helper('adminhtml')->__('[ENV]'),
         ];
     }
 
@@ -376,7 +378,7 @@ public function initFields($fieldset, $group, $section, $fieldPrefix = '', $labe
                     }
                 }
 
-                $field = $fieldset->addField($id, $fieldType, [
+                $elementFieldData = [
                     'name'                  => $name,
                     'label'                 => $label,
                     'comment'               => $comment,
@@ -391,7 +393,14 @@ public function initFields($fieldset, $group, $section, $fieldPrefix = '', $labe
                     'scope_label'           => $this->getScopeLabel($element),
                     'can_use_default_value' => $this->canUseDefaultValue((int) $element->show_in_default),
                     'can_use_website_value' => $this->canUseWebsiteValue((int) $element->show_in_website),
-                ]);
+                ];
+                if ($this->isOverwrittenByEnvVariable($path)) {
+                    $elementFieldData['scope_label'] = $this->_scopeLabels[static::SCOPE_ENV];
+                    $elementFieldData['disabled'] = 1;
+                    $elementFieldData['can_use_default_value'] = 0;
+                    $elementFieldData['can_use_website_value'] = 0;
+                }
+                $field = $fieldset->addField($id, $fieldType, $elementFieldData);
                 $this->_prepareFieldOriginalData($field, $element);
 
                 if (isset($element->validate)) {
@@ -629,6 +638,17 @@ public function getScope()
         return $scope;
     }
 
+    /**
+     * Returns true if element was overwritten by ENV variable
+     */
+    public function isOverwrittenByEnvVariable(string $path): bool
+    {
+        /** @var Mage_Core_Helper_EnvironmentConfigLoader $environmentConfigLoaderHelper */
+        $environmentConfigLoaderHelper = Mage::helper('core/environmentConfigLoader');
+        $path = $this->getScope() . '/' . $path;
+        return $environmentConfigLoaderHelper->hasPath($path);
+    }
+
     /**
      * Retrieve label for scope
      *

app/code/core/Mage/Adminhtml/Model/Config/Data.php

@@ -349,6 +349,13 @@ protected function _getPathConfig($path, $full = true)
                 $config[$data->getPath()] = $data->getValue();
             }
         }
+
+        if (!$full) {
+            /** @var Mage_Core_Helper_EnvironmentConfigLoader $environmentConfigLoaderHelper */
+            $environmentConfigLoaderHelper = Mage::helper('core/environmentConfigLoader');
+            $envConfig = $environmentConfigLoaderHelper->getAsArray($this->getScope());
+            $config = array_merge($config, $envConfig);
+        }
         return $config;
     }
 

app/code/core/Mage/Core/Helper/EnvironmentConfigLoader.php

@@ -22,6 +22,7 @@
 class Mage_Core_Helper_EnvironmentConfigLoader extends Mage_Core_Helper_Abstract
 {
     protected const ENV_STARTS_WITH = 'OPENMAGE_CONFIG';
+    protected const ENV_FEATURE_ENABLED = 'OPENMAGE_CONFIG_OVERRIDE_ALLOWED';
     protected const ENV_KEY_SEPARATOR = '__';
     protected const CONFIG_KEY_DEFAULT = 'DEFAULT';
     protected const CONFIG_KEY_WEBSITES = 'WEBSITES';
@@ -57,6 +58,10 @@ class Mage_Core_Helper_EnvironmentConfigLoader extends Mage_Core_Helper_Abstract
      */
     public function overrideEnvironment(Varien_Simplexml_Config $xmlConfig)
     {
+        $data = Mage::registry('current_env_config');
+        if ($data) {
+            return;
+        }
         $env = $this->getEnv();
 
         foreach ($env as $configKey => $value) {
@@ -70,18 +75,116 @@ public function overrideEnvironment(Varien_Simplexml_Config $xmlConfig)
                 case static::CONFIG_KEY_DEFAULT:
                     list($unused1, $unused2, $section, $group, $field) = $configKeyParts;
                     $path = $this->buildPath($section, $group, $field);
-                    $xmlConfig->setNode($this->buildNodePath($scope, $path), $value);
+                    $nodePath = $this->buildNodePath($scope, $path);
+                    $xmlConfig->setNode($nodePath, $value);
+                    try {
+                        foreach (['0', 'admin'] as $store) {
+                            $store = Mage::app()->getStore($store);
+                            $this->setCache($store, $value, $path);
+                        }
+                    } catch (Throwable $exception) {
+                        // invalid store, intentionally empty
+                    }
                     break;
 
                 case static::CONFIG_KEY_WEBSITES:
                 case static::CONFIG_KEY_STORES:
-                    list($unused1, $unused2, $code, $section, $group, $field) = $configKeyParts;
+                    list($unused1, $unused2, $storeCode, $section, $group, $field) = $configKeyParts;
                     $path = $this->buildPath($section, $group, $field);
-                    $nodePath = sprintf('%s/%s/%s', strtolower($scope), strtolower($code), $path);
+                    $storeCode = strtolower($storeCode);
+                    $scope = strtolower($scope);
+                    $nodePath = sprintf('%s/%s/%s', $scope, $storeCode, $path);
                     $xmlConfig->setNode($nodePath, $value);
+                    try {
+                        if (!str_contains($nodePath, 'websites')) {
+                            foreach ([$storeCode, 'admin'] as $store) {
+                                $store = Mage::app()->getStore($store);
+                                $this->setCache($store, $value, $path);
+                            }
+                        }
+                    } catch (Throwable $exception) {
+                        // invalid store, intentionally empty
+                    }
+                    break;
+            }
+        }
+        Mage::register('current_env_config', true, true);
+    }
+
+    public function hasPath(string $wantedPath): bool
+    {
+        $data = Mage::registry("config_env_has_path_$wantedPath");
+        if ($data !== null) {
+            return $data;
+        }
+        $env = $this->getEnv();
+        $config = [];
+
+        foreach ($env as $configKey => $value) {
+            if (!$this->isConfigKeyValid($configKey)) {
+                continue;
+            }
+
+            list($configKeyParts, $scope) = $this->getConfigKey($configKey);
+
+            switch ($scope) {
+                case static::CONFIG_KEY_DEFAULT:
+                    list($unused1, $unused2, $section, $group, $field) = $configKeyParts;
+                    $path = $this->buildPath($section, $group, $field);
+                    $nodePath = $this->buildNodePath($scope, $path);
+                    $config[$nodePath] = $value;
+                    break;
+
+                case static::CONFIG_KEY_WEBSITES:
+                case static::CONFIG_KEY_STORES:
+                    list($unused1, $unused2, $storeCode, $section, $group, $field) = $configKeyParts;
+                    $path = $this->buildPath($section, $group, $field);
+                    $nodePath = $this->buildNodePath($scope, $path);
+                    $config[$nodePath] = $value;
+                    break;
+            }
+        }
+        $hasConfig = array_key_exists($wantedPath, $config);
+        Mage::register("config_env_has_path_$wantedPath", $hasConfig);
+        return $hasConfig;
+    }
+
+    public function getAsArray(string $wantedScope): array
+    {
+        $data = Mage::registry("config_env_array_$wantedScope");
+        if ($data !== null) {
+            return $data;
+        }
+        $env = $this->getEnv();
+        $config = [];
+
+        foreach ($env as $configKey => $value) {
+            if (!$this->isConfigKeyValid($configKey)) {
+                continue;
+            }
+
+            list($configKeyParts, $scope) = $this->getConfigKey($configKey);
+            if (strtolower($scope) !== strtolower($wantedScope)) {
+                continue;
+            }
+
+            switch ($scope) {
+                case static::CONFIG_KEY_DEFAULT:
+                    list($unused1, $unused2, $section, $group, $field) = $configKeyParts;
+                    $path = $this->buildPath($section, $group, $field);
+                    $config[$path] = $value;
+                    break;
+
+                case static::CONFIG_KEY_WEBSITES:
+                case static::CONFIG_KEY_STORES:
+                    list($unused1, $unused2, $storeCode, $section, $group, $field) = $configKeyParts;
+                    $path = $this->buildPath($section, $group, $field);
+                    $config[$path] = $value;
                     break;
             }
         }
+        Mage::register("config_env_array_$wantedScope", $config);
+        return $config;
     }
 
     /**
@@ -95,11 +198,29 @@ public function setEnvStore(array $envStorage): void
     public function getEnv(): array
     {
         if (empty($this->envStore)) {
-            $this->envStore = getenv();
+            $env = getenv();
+            $env = array_filter($env, function ($key) {
+                return str_starts_with($key, static::ENV_STARTS_WITH);
+            }, ARRAY_FILTER_USE_KEY);
+            $this->envStore = $env;
+        }
+        if (!isset($this->envStore[static::ENV_FEATURE_ENABLED])) {
+            $this->envStore = [];
+            return $this->envStore;
         }
         return $this->envStore;
     }
 
+    protected function setCache(Mage_Core_Model_Store $store, $value, string $path): void
+    {
+        $refObject = new ReflectionObject($store);
+        $refProperty = $refObject->getProperty('_configCache');
+        $refProperty->setAccessible(true);
+        $configCache = $refProperty->getValue($store);
+        $configCache[$path] = $value;
+        $refProperty->setValue($store, $configCache);
+    }
+
     protected function getConfigKey(string $configKey): array
     {
         $configKeyParts = array_filter(
@@ -115,10 +236,6 @@ protected function getConfigKey(string $configKey): array
 
     protected function isConfigKeyValid(string $configKey): bool
     {
-        if (!str_starts_with($configKey, static::ENV_STARTS_WITH)) {
-            return false;
-        }
-
         $sectionGroupFieldRegexp = sprintf('([%s]*)', implode('', static::ALLOWED_CHARS));
         $allowedChars = sprintf('[%s]', implode('', static::ALLOWED_CHARS));
         $regexp = '/' . static::ENV_STARTS_WITH . static::ENV_KEY_SEPARATOR . '(WEBSITES' . static::ENV_KEY_SEPARATOR

app/code/core/Mage/Core/Model/Store.php

@@ -344,6 +344,9 @@ public function getConfig($path)
         }
 
         $config = Mage::getConfig();
+        /** @var Mage_Core_Helper_EnvironmentConfigLoader $environmentConfigLoaderHelper */
+        $environmentConfigLoaderHelper = Mage::helper('core/environmentConfigLoader');
+        $environmentConfigLoaderHelper->overrideEnvironment($config);
 
         $fullPath = 'stores/' . $this->getCode() . '/' . $path;
         $data = $config->getNode($fullPath);