Skip to content

Fix : admin theme changed by default config value #4756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Hanmac wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix : admin theme changed by default config value #4756

Hanmac wants to merge 6 commits into from

Conversation

@Hanmac
Copy link
Contributor

@Hanmac Hanmac commented Apr 17, 2025 •
edited by sreichel
Loading

Description (*)

Done by Suggestion of #1216 (comment)

Related Pull Requests

  • see OpenMage/magento-lts#<issue_number>

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@Hanmac Hanmac added Component: Adminhtml Relates to Mage_Adminhtml XML Layout labels Apr 17, 2025
@github-actions github-actions bot added Component: PayPal Relates to Mage_Paypal Component: Core Relates to Mage_Core Component: Catalog Relates to Mage_Catalog Template : admin Relates to admin template Component: Cms Relates to Mage_Cms Component: Reports Relates to Mage_Reports Component: AdminNotification Relates to Mage_AdminNotification Component: Sales Relates to Mage_Sales Component: Usa Relates to Mage_Usa Component: Customer Relates to Mage_Customer Component: Eav Relates to Mage_Eav Component: Page Relates to Mage_Page Component: Api PageRelates to Mage_Api Component: Captcha Relates to Mage_Captcha Component: Tag Relates to Mage_Tag Component: CurrencySymbol Relates to Mage_CurrencySymbol Component: Admin Relates to Mage_Admin Component: Widget Relates to Mage_Widget Component: Weee Relates to Mage_Weee Component: Tax Relates to Mage_Tax Component: Review Relates to Mage_Review Component: Rating Relates to Mage_Rating Component: Payment Relates to Mage_Payment Component: Oauth Relates to Mage_Oauth Component: Newsletter Relates to Mage_Newsletter Component: Index Relates to Mage_Index Component: Giftmessage Relates to Mage_Giftmessage and removed XML Layout labels Apr 17, 2025
@sreichel sreichel added this to the 20.17.0 milestone Oct 22, 2025
@Hanmac Hanmac force-pushed the designLayoutUpdates branch from 33e5a3f to 431b0dd Compare November 25, 2025 15:50
@Hanmac Hanmac force-pushed the designLayoutUpdates branch from deb0f8f to 13f375e Compare December 15, 2025 14:22
@sreichel sreichel modified the milestones: 20.17.0, 20.18.0 Dec 17, 2025
theroch
theroch previously approved these changes Dec 29, 2025
View reviewed changes
@addison74
Copy link
Contributor

addison74 commented Dec 29, 2025

Lots of conflicts.

@Hanmac Hanmac force-pushed the designLayoutUpdates branch from fc382d0 to f604932 Compare December 30, 2025 08:06
@theroch
Copy link
Contributor

theroch commented Dec 30, 2025

I've tested with:
gh pr checkout 4756
and merge main into PR4756. There were no merge conflicts.
All themes worked as expected.

@Hanmac
Copy link
Contributor Author

Hanmac commented Dec 30, 2025

i made an extra MR for the Rector thing: #5197

theroch
theroch previously approved these changes Dec 30, 2025
View reviewed changes
@sreichel
Copy link
Contributor

sreichel commented Dec 31, 2025 •
edited
Loading

Tested.

Works - but ...

  • cache needs updated?

Add to install script?

@sreichel sreichel changed the title Fix #1216 and the fallback theme Fix : admin theme changed by default config value Jan 1, 2026
@sreichel sreichel added the bug label Jan 1, 2026
@Hanmac Hanmac force-pushed the designLayoutUpdates branch from 063628e to 37e7ffb Compare January 1, 2026 13:05
sreichel
sreichel reviewed Jan 2, 2026
View reviewed changes
sreichel
sreichel reviewed Jan 2, 2026
View reviewed changes
sreichel
sreichel reviewed Jan 2, 2026
View reviewed changes
@sreichel sreichel modified the milestones: 20.18.0, 20.17.0 Jan 2, 2026
@theroch
Copy link
Contributor

theroch commented Jan 2, 2026 

* cache needs updated?

Add to install script?

Is it not always necessary or meaningful to flush the cache when installing an update for the shop?
From my point of view, there is no script necessary.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 2, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
13.6% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sreichel sreichel sreichel left review comments

@theroch theroch theroch left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

bug Component: Admin Relates to Mage_Admin Component: Adminhtml Relates to Mage_Adminhtml Component: AdminNotification Relates to Mage_AdminNotification Component: Api PageRelates to Mage_Api Component: Api2 Relates to Mage_Api2 Component: Authorizenet Relates to Mage_Authorizenet Component: Bundle Relates to Mage_Bundle Component: Captcha Relates to Mage_Captcha Component: Catalog Relates to Mage_Catalog Component: CatalogSearch Relates to Mage_CatalogSearch Component: Centinel Relates to Mage_Centinel Component: Cms Relates to Mage_Cms Component: Core Relates to Mage_Core Component: CurrencySymbol Relates to Mage_CurrencySymbol Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Directory Relates to Mage_Directory Component: Downloadable Relates to Mage_Downloadable Component: Eav Relates to Mage_Eav Component: Giftmessage Relates to Mage_Giftmessage Component: ImportExport Relates to Mage_ImportExport Component: Index Relates to Mage_Index Component: Media Relates to Mage_Media Component: Newsletter Relates to Mage_Newsletter Component: Oauth Relates to Mage_Oauth Component: Page Relates to Mage_Page Component: Paygate Relates to Mage_Paygate Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Component: Rating Relates to Mage_Rating Component: Reports Relates to Mage_Reports Component: Review Relates to Mage_Review Component: Rss Relates to Mage_Rss Component: Sales Relates to Mage_Sales Component: Tag Relates to Mage_Tag Component: Tax Relates to Mage_Tax Component: Usa Relates to Mage_Usa Component: Weee Relates to Mage_Weee Component: Widget Relates to Mage_Widget phpstan Template : admin Relates to admin template

Projects

None yet

Milestone

20.17.0

Development

Successfully merging this pull request may close these issues.

Admin theme changed by default config value

4 participants

@Hanmac @sreichel @theroch @addison74