Added Cypress E2E tests

.cypress.config.js

@@ -1,8 +1,8 @@
 module.exports = {
-  e2e: {
-    setupNodeEvents(on, config) {
-      // implement node event listeners here
-    },
-    baseUrl: 'https://magento-lts.ddev.site'
-  },
+    e2e: {
+        setupNodeEvents(on, config) {
+            // implement node event listeners here
+        },
+        baseUrl: 'https://magento-lts.ddev.site',
+    }
 };

.github/labeler.yml

@@ -934,4 +934,10 @@
       - any-glob-to-any-file: [
         .rector.php,
         .github/workflows/rector.yml
-      ]
+      ]
+
+'cypress':
+  - changed-files:
+      - any-glob-to-any-file: [
+        cypress/*
+      ]

.github/workflows/check-files.yml

@@ -39,6 +39,9 @@ on:
       phpunit:
         description: "Count changed PHPUnit files"
         value: ${{ jobs.check.outputs.phpunit }}
+      cypress:
+        description: "Count changed Cypress files"
+        value: ${{ jobs.check.outputs.cypress }}
   # Allow manually triggering the workflow.
   workflow_dispatch:
 
@@ -59,6 +62,7 @@ jobs:
       phpstan: ${{ steps.changes-phpstan.outputs.phpstan }}
       phpunit-test: ${{ steps.changes-phpunit-test.outputs.phpunit-test }}
       phpunit: ${{ steps.changes-phpunit.outputs.phpunit }}
+      cypress: ${{ steps.changes-cypress.outputs.cypress }}
 
     steps:
       - name: Checkout code
@@ -194,3 +198,11 @@ jobs:
           count="$(grep -oE "**phpunit**" <<< "${{ steps.changed-files-specific.outputs.all_modified_files }}" | wc -l)"
           echo "$count PHPUnit file(s) changed"
           echo "phpunit=$count" >> $GITHUB_OUTPUT
+
+      - name: Check if Cypress files changed
+        id: changes-cypress
+        if: steps.changed-files-specific.outputs.any_modified == 'true'
+        run: |
+          count="$(grep -oE "cypress/" <<< "${{ steps.changed-files-specific.outputs.all_modified_files }}" | wc -l)"
+          echo "$count Cypress file(s) changed"
+          echo "cypress=$count" >> $GITHUB_OUTPUT

.github/workflows/cypress.yml

@@ -0,0 +1,39 @@
+name: Cypress
+
+on:
+  workflow_call:
+  # Allow manually triggering the workflow.
+  workflow_dispatch:
+
+jobs:
+  test:
+    name: Cypress
+    runs-on: [ubuntu-latest]
+    strategy:
+      matrix:
+        webserver: ['apache-fpm', 'nginx-fpm']
+
+    steps:
+      - uses: actions/checkout@v1
+      - name: Setup DDEV
+        uses: ddev/github-action-setup-ddev@v1
+        with:
+          autostart: false
+
+      # install DDEV configuration
+      - run: ddev config --project-type=magento --php-version=8.1 --webserver-type=${{ matrix.webserver }}
+
+      # install composer dependencies
+      - run: ddev composer install
+
+      # install openmage
+      - run: ddev openmage-install -q
+
+      # install cypress-addon
+      - run: ddev add-on get tyler36/ddev-cypress
+
+      # start ddev
+      - run: ddev start
+
+        # run cypress
+      - run: ddev cypress-run --config-file .cypress.config.js

.github/workflows/workflow.yml

@@ -136,3 +136,14 @@ jobs:
       needs.check.outputs.phpunit > 0 ||
       needs.check.outputs.workflow > 0
     uses: ./.github/workflows/phpunit.yml
+
+  cypress:
+    name: Cypress E2E Tests
+    needs: [check, php-cs-fixer]
+    if: |
+      needs.check.outputs.cypress > 0 ||
+      needs.check.outputs.php > 0 ||
+      needs.check.outputs.phtml > 0 ||
+      needs.check.outputs.xml > 0 ||
+      needs.check.outputs.workflow > 0
+    uses: ./.github/workflows/cypress.yml

.gitignore

@@ -114,5 +114,9 @@ app/etc/includes/ddev.xhgui.php
 # local development
 .localdev
 
+# cypress
+cypress/screenshots/
+cypress/videos/
+
 # rector
 .rector.result.cache

app/code/core/Mage/Adminhtml/Block/Widget/Container.php

@@ -253,7 +253,7 @@ public function getHeaderText()
      */
     public function getHeaderCssClass()
     {
-        return 'head-' . strtr($this->_controller, '_', '-');
+        return 'icon-head head-' . strtr($this->_controller, '_', '-');
     }
 
     /**

app/code/core/Mage/Sitemap/etc/system.xml

@@ -48,7 +48,7 @@
                             <show_in_website>1</show_in_website>
                             <show_in_store>1</show_in_store>
                             <comment>Valid values range: from 0.0 to 1.0.</comment>
-                            <frontend_class>validate-number</frontend_class>
+                            <validate>required-entry validate-number validate-number-range number-range-0-1</validate>
                         </priority>
                         <lastmod translate="label">
                             <label>Show lastmod</label>
@@ -85,7 +85,7 @@
                             <show_in_website>1</show_in_website>
                             <show_in_store>1</show_in_store>
                             <comment>Valid values range: from 0.0 to 1.0.</comment>
-                            <frontend_class>validate-number</frontend_class>
+                            <validate>required-entry validate-number validate-number-range number-range-0-1</validate>
                         </priority>
                         <lastmod translate="label">
                             <label>Show lastmod</label>
@@ -122,7 +122,7 @@
                             <show_in_website>1</show_in_website>
                             <show_in_store>1</show_in_store>
                             <comment>Valid values range: from 0.0 to 1.0.</comment>
-                            <frontend_class>validate-number</frontend_class>
+                            <validate>required-entry validate-number validate-number-range number-range-0-1</validate>
                         </priority>
                         <lastmod translate="label">
                             <label>Show lastmod</label>

app/design/adminhtml/default/default/template/system/config/tabs.phtml

@@ -28,7 +28,7 @@
         <?php $_iterator = 1; ?>
         <?php foreach ($_tab->getSections() as $_section): ?>
             <dd>
-                <a href="<?php echo $_section->getUrl() ?>" class="<?php echo $_section->getClass() ?><?php if($_section->getId()==$this->getActiveSection()): ?> active<?php endif ?> <?php echo $_section->getIsLast()?'last':'' ?>">
+                <a href="<?php echo $_section->getUrl() ?>" id="section-<?php echo $_section->getId() ?>" class="<?php echo $_section->getClass() ?><?php if($_section->getId()==$this->getActiveSection()): ?> active<?php endif ?> <?php echo $_section->getIsLast()?'last':'' ?>">
                     <span <?php if($_tab->getId()==$this->getActiveTab()): ?>class="active"<?php endif ?>>
                         <?php echo $_section->getLabel() ?>
                     </span>

cypress/e2e/openmage/backend/catalog/categories.cy.js

@@ -0,0 +1,12 @@
+const route = cy.testRoutes.backend.catalog.categories
+
+describe(`Checks admin system "${route.h3}"`, () => {
+    beforeEach('Log in the user', () => {
+        cy.adminLogIn();
+        cy.adminGoToTestRoute(route);
+    });
+
+    it(`tests classes and title`, () => {
+        cy.adminTestRoute(route);
+    });
+});

cypress/e2e/openmage/backend/catalog/products.cy.js

@@ -0,0 +1,20 @@
+const route = cy.testRoutes.backend.catalog.products
+
+describe(`Checks admin system "${route.h3}"`, () => {
+    beforeEach('Log in the user', () => {
+        cy.adminLogIn();
+        cy.adminGoToTestRoute(route);
+    });
+
+    it(`tests classes and title`, () => {
+        cy.adminTestRoute(route);
+    });
+
+    it(`tests filter options`, () => {
+        cy.log('Checking for the number of filter type options');
+        cy.get('#productGrid_product_filter_type option').should('have.length', 7);
+
+        cy.log('Checking for the number of filter visibility options');
+        cy.get('#productGrid_product_filter_visibility option').should('have.length', 5);
+    });
+});

cypress/e2e/openmage/backend/catalog/search.cy.js

@@ -0,0 +1,12 @@
+const route = cy.testRoutes.backend.catalog.search
+
+describe(`Checks admin system "${route.h3}"`, () => {
+    beforeEach('Log in the user', () => {
+        cy.adminLogIn();
+        cy.adminGoToTestRoute(route);
+    });
+
+    it(`tests classes and title`, () => {
+        cy.adminTestRoute(route);
+    });
+});

cypress/e2e/openmage/backend/catalog/sitemap.cy.js

@@ -0,0 +1,12 @@
+const route = cy.testRoutes.backend.catalog.sitemap
+
+describe(`Checks admin system "${route.h3}"`, () => {
+    beforeEach('Log in the user', () => {
+        cy.adminLogIn();
+        cy.adminGoToTestRoute(route);
+    });
+
+    it(`tests classes and title`, () => {
+        cy.adminTestRoute(route);
+    });
+});

cypress/e2e/openmage/backend/catalog/urlrewrites.cy.js

@@ -0,0 +1,12 @@
+const route = cy.testRoutes.backend.catalog.urlrewrite
+
+describe(`Checks admin system "${route.h3}"`, () => {
+    beforeEach('Log in the user', () => {
+        cy.adminLogIn();
+        cy.adminGoToTestRoute(route);
+    });
+
+    it(`tests classes and title`, () => {
+        cy.adminTestRoute(route);
+    });
+});

cypress/e2e/openmage/backend/cms/block.cy.js

@@ -0,0 +1,12 @@
+const route = cy.testRoutes.backend.cms.block
+
+describe(`Checks admin system "${route.h3}"`, () => {
+    beforeEach('Log in the user', () => {
+        cy.adminLogIn();
+        cy.adminGoToTestRoute(route);
+    });
+
+    it(`tests classes and title`, () => {
+        cy.adminTestRoute(route);
+    });
+});

cypress/e2e/openmage/backend/cms/page.cy.js

@@ -0,0 +1,12 @@
+const route = cy.testRoutes.backend.cms.page
+
+describe(`Checks admin system "${route.h3}"`, () => {
+    beforeEach('Log in the user', () => {
+        cy.adminLogIn();
+        cy.adminGoToTestRoute(route);
+    });
+
+    it(`tests classes and title`, () => {
+        cy.adminTestRoute(route);
+    });
+});

cypress/e2e/openmage/backend/cms/widget.cy.js

@@ -0,0 +1,12 @@
+const route = cy.testRoutes.backend.cms.widget
+
+describe(`Checks admin system "${route.h3}"`, () => {
+    beforeEach('Log in the user', () => {
+        cy.adminLogIn();
+        cy.adminGoToTestRoute(route);
+    });
+
+    it(`tests classes and title`, () => {
+        cy.adminTestRoute(route);
+    });
+});

cypress/e2e/openmage/backend/customer/group.cy.js

@@ -0,0 +1,12 @@
+const route = cy.testRoutes.backend.customers.groups
+
+describe(`Checks admin system "${route.h3}"`, () => {
+    beforeEach('Log in the user', () => {
+        cy.adminLogIn();
+        cy.adminGoToTestRoute(route);
+    });
+
+    it(`tests classes and title`, () => {
+        cy.adminTestRoute(route);
+    });
+});

cypress/e2e/openmage/backend/customer/manage.cy.js

@@ -0,0 +1,12 @@
+const route = cy.testRoutes.backend.customers.manage
+
+describe(`Checks admin system "${route.h3}"`, () => {
+    beforeEach('Log in the user', () => {
+        cy.adminLogIn();
+        cy.adminGoToTestRoute(route);
+    });
+
+    it(`tests classes and title`, () => {
+        cy.adminTestRoute(route);
+    });
+});

cypress/e2e/openmage/backend/customer/online.cy.js

@@ -0,0 +1,12 @@
+const route = cy.testRoutes.backend.customers.online
+
+describe(`Checks admin system "${route.h3}"`, () => {
+    beforeEach('Log in the user', () => {
+        cy.adminLogIn();
+        cy.adminGoToTestRoute(route);
+    });
+
+    it(`tests classes and title`, () => {
+        cy.adminTestRoute(route);
+    });
+});

cypress/e2e/openmage/backend/login.cy.js

@@ -0,0 +1,33 @@
+describe('Check admin login', () => {
+    beforeEach('Log in the user', () => {
+        cy.visit('/admin');
+    });
+
+    const login = cy.openmage.login.admin
+
+    it('tests valid login', () => {
+        const username = login.username.value;
+        const password = login.password.value;
+
+        cy.log(`Logging in as ${username}`);
+        cy.get(login.username._id).clear().type(username).should('have.value', username);
+        cy.get(login.password._id).clear().type(password).should('have.value', password);
+        cy.get(login._submit.__selector).click();
+    })
+
+    it('tests invalid login', () => {
+        const username = 'abc';
+        const password = '123';
+
+        cy.log(`Logging in as ${username}`);
+        cy.get(login.username._id).clear().type(username).should('have.value', username);
+        cy.get(login.password._id).clear().type(password).should('have.value', password);
+        cy.get(login._submit.__selector).click();
+    })
+
+    it('tests empty login', () => {
+        cy.get(login.username._id).clear().should('have.value', '');
+        cy.get(login.password._id).clear().should('have.value', '');
+        cy.get(login._submit.__selector).click();
+    })
+})

cypress/e2e/openmage/backend/newsletter/queue.cy.js

@@ -0,0 +1,12 @@
+const route = cy.testRoutes.backend.newsletter.queue
+
+describe(`Checks admin system "${route.h3}"`, () => {
+    beforeEach('Log in the user', () => {
+        cy.adminLogIn();
+        cy.adminGoToTestRoute(route);
+    });
+
+    it(`tests classes and title`, () => {
+        cy.adminTestRoute(route);
+    });
+});

cypress/e2e/openmage/backend/newsletter/report.cy.js

@@ -0,0 +1,12 @@
+const route = cy.testRoutes.backend.newsletter.report
+
+describe(`Checks admin system "${route.h3}"`, () => {
+    beforeEach('Log in the user', () => {
+        cy.adminLogIn();
+        cy.adminGoToTestRoute(route);
+    });
+
+    it(`tests classes and title`, () => {
+        cy.adminTestRoute(route);
+    });
+});