Fix product detail swatches when listing attribute is "-- Please Select --" #5187

Copilot · 2025-12-22T22:07:19Z

When "Product Attribute to Use for Swatches in Product Listing" is explicitly set to "-- Please Select --", the config returns an empty string. The isEnabled() helper checks both the enabled flag AND the listing attribute, causing product detail swatches to fail even when detail attributes are properly configured.

Changes

Decouple product detail swatches from listing attribute requirement:

Helper/Data::getSwatchesProductJs() - Check CONFIG_PATH_ENABLED directly instead of isEnabled(), verify detail swatch attributes exist
Block/.../Swatches::shouldRender() - Check CONFIG_PATH_ENABLED directly to allow detail page rendering
Block/.../Product::_toHtml() - Override to bypass parent's isEnabled() check, call grandparent class directly

Unchanged behavior:

Product listing functionality still requires listing attribute via isEnabled() check in Observer
Empty string from "-- Please Select --" now behaves identically to unconfigured (null) state

// Before: fails when listing attribute is ""
if ($this->isEnabled() && $product) { ... }

// After: works independently
if (Mage::getStoreConfigFlag(self::CONFIG_PATH_ENABLED) && $product) {
    $configAttrs = $this->getSwatchAttributeIds();
    if (!empty($configAttrs)) { ... }
}

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

https://api.github.com/repos/CarbonPHP/carbon-doctrine-types/zipball/18ba5ddfec8976260ead6e866180bd5d2f71aa1d
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/CarbonPHP/carbon/zipball/9228ce90e1035ff2f0db84b40ec2e023ed802075
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/MyIntervals/PHP-CSS-Parser/zipball/1b363fdbdc6dd0ca0f4bf98d3a4d7f388133f1fb
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/MyIntervals/emogrifier/zipball/3548212a1b4232a4a6ad344992f551725b3de295
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/OpenMage/dev-translations/zipball/cac06c24c2bc32eb7c75eb414708070da9648b9a
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/PHP-CS-Fixer/PHP-CS-Fixer/zipball/2ba8f5a60f6f42fb65758cfb3768434fa2d1c7e8
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/PHPCSStandards/PHP_CodeSniffer/zipball/0ca86845ce43291e8f5692c7356fccf3bcf02bf4
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/PHPCompatibility/PHPCompatibility/zipball/9fb324479acf6f39452e0655d2429cc0d3914243
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/zipball/cf1b83b1ef7615dd53f70864c9e7f496b1ec0fd1
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/Seldaek/jsonlint/zipball/1748aaf847fc731cfad7725aec413ee46f0cc3a2
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/Seldaek/monolog/zipball/10d85740180ecba7896c87e06a166e0c95a0e3b6
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/Seldaek/phar-utils/zipball/ea2f4014f163c1be4c601b9b7bd6af81ba8d701c
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/Seldaek/signal-handler/zipball/04a6112e883ad76c0ada8e4a9f7520bbfdb6bb98
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/chartjs/Chart.js/zipball/9c5cf9fac7ec04a71b516e2aff3f7d76876be369
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/clue/reactphp-ndjson/zipball/392dc165fce93b5bb5c637b67e59619223c931b0
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/colinmollenhour/Cm_Cache_Backend_Redis/zipball/d403f4473e1b3cc616fa59d187e817543b6620c1
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/colinmollenhour/Cm_RedisSession/zipball/d86fc3789f884cb4b04a9353022a9a8ce89efbbd
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/colinmollenhour/credis/zipball/f4930b426f6b1238b687a1ffe6ee5af7f835b40a
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/colinmollenhour/php-redis-session-abstract/zipball/defae6e34b0f6ce42e4be4f14f529d8932aea73a
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/components/jquery/zipball/8edc7785239bb8c2ad2b83302b856a1d61de60e7
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/composer/ca-bundle/zipball/719026bb30813accb68271fee7e39552a58e9f65
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/composer/class-map-generator/zipball/ba9f089655d4cdd64e762a6044f411ccdaec0076
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/composer/composer/zipball/937c775a644bd7d2c3dfbb352747488463a6e673
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/composer/metadata-minifier/zipball/c549d23829536f0d0e984aaabbf02af91f443207
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/composer/pcre/zipball/b2bed4734f0cc156ee1fe9c0da2550420d99a21e
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/composer/semver/zipball/198166618906cb2de69b95d7d47e5fa8aa1b2b95
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/composer/spdx-licenses/zipball/edf364cefe8c43501e21e88110aac10b284c3c9f
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/composer/xdebug-handler/zipball/6c1925561632e83d60a44492e0b344cf48ab85ef
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/cweagans/composer-patches/zipball/e190d4466fe2b103a55467dfa83fc2fecfcaf2db
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/doctrine/inflector/zipball/6d6c96277ea252fc1304627204c3d5e6e15faa3b
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/empiricompany/openmage_ignition/zipball/4e89eedc5bcbde918d2b012ec03608cb2e8272e7
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/ezyang/htmlpurifier/zipball/b287d2a16aceffbf6e0295559b39662612b77fcf
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/flowjs/flow.js/zipball/3d4ba3a1b9906b31551f33ae649e6fd6b95cf711
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/igorw/evenement/zipball/0a16b0d71ab13284339abb99d9d2bd813640efbc
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/illuminate/collections/zipball/6ae9c74fa92d4e1824d1b346cd435e8eacdc3232
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/illuminate/conditionable/zipball/47c700320b7a419f0d188d111f3bbed978fcbd3f
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/illuminate/contracts/zipball/2393ef579e020d88e24283913c815c3e2c143323
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/illuminate/macroable/zipball/dff667a46ac37b634dcf68909d9d41e94dc97c27
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/illuminate/pipeline/zipball/c12e4f1d8a1fbecdc1e0fa4dc9fe17b4315832e9
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/illuminate/support/zipball/28b505e671dbe119e4e32a75c78f87189d046e39
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/macopedia/phpstan-magento1/zipball/01418cc9a536ffbf298fdf7ea3b9fac1f87a0508
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/magento-ecg/coding-standard/zipball/1db1da45447682108c63ea94ce07119a002a6504
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/mklkj/tinymce-i18n/zipball/a667275880c1a2b047e848d1a484495c240c2750
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/paragonie/constant_time_encoding/zipball/d5b01a39b3415c2cd581d3bd3a3575c1ebbd8e77
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/paragonie/random_compat/zipball/996434e5492cb4c3edcb9168db6fbb1359ef965a
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/pdepend/pdepend/zipball/f942b208dc2a0868454d01b29f0c75bbcfc6ed58
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/perftools/php-profiler/zipball/1105db3deded46d56879900d22c447808e39d0a9
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/php-fig/clock/zipball/e41a24703d4560fd0acb709162f73b8adfc3aa0d
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/php-fig/container/zipball/c71ecc56dfe541dbd90c5360474fbc405f8d5963
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/php-fig/event-dispatcher/zipball/dbefd12671e8a14ec7f180cab83036ed26714bb0
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/php-fig/log/zipball/ef29f6d262798707a9edd554e2b82517ef3a9376
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/php-fig/simple-cache/zipball/764e0b3939f5ca87cb904f570ef9be2d78a07865
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/phpmd/phpmd/zipball/74a1f56e33afad4128b886e334093e98e1b5e7c0
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/phpseclib/mcrypt_compat/zipball/cd248c07cc7b09dc73d568199eff5e8ddc4aff0d
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/phpseclib/phpseclib/zipball/64065a5679c50acb886e82c07aa139b0f757bb89
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/phpstan/phpstan-phpunit/zipball/5e30669bef866eff70db8b58d72a5c185aa82414
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/phpstan/phpstan-strict-rules/zipball/d6211c46213d4181054b3d77b10a5c5cb0d59538
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/reactphp/cache/zipball/d47c472b64aa5608225f47965a484b75c7817d5b
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/reactphp/child-process/zipball/1721e2b93d89b745664353b9cfc8f155ba8a6159
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/reactphp/dns/zipball/7562c05391f42701c1fccf189c8225fece1cd7c3
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/reactphp/event-loop/zipball/ba276bda6083df7e0050fd9b33f66ad7a4ac747a
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/reactphp/promise/zipball/23444f53a813a3296c1368bb104793ce8d88f04a
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/reactphp/socket/zipball/ef5b17b81f6f60504c539313f94f2d826c5faa08
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/reactphp/stream/zipball/1e5b0acb8fe55143b5b426817155190eb6f5b18d
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/sebastianbergmann/diff/zipball/ba01945089c3a293b01ba9badc29ad55b106b0bc
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/sebastianbergmann/resource-operations/zipball/05d5692a7993ecccd56a03e40cd7e5b09b1d404e
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/sebastianbergmann/type/zipball/75e2c2a32f5e0b3aef905b9ed0b179b953b3d7c7
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/sebastianbergmann/version/zipball/c6c1022351a901512170118436c764e473f6de8c
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/spatie/backtrace/zipball/8c0f16a59ae35ec8c62d85c3c17585158f430110
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/spatie/error-solutions/zipball/e495d7178ca524f2dd0fe6a1d99a1e608e1c9936
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/spatie/flare-client-php/zipball/bf1716eb98bd689451b071548ae9e70738dce62f
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/spatie/ignition/zipball/31f314153020aee5af3537e507fef892ffbf8c85
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/symfony/config/zipball/80e2cf005cf17138c97193be0434cdcfd1b2212e
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/symfony/console/zipball/c4ba980ca61a9eb18ee6bcc73f28e475852bb1ed
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/symfony/css-selector/zipball/9b784413143701aa3c94ac1869a159a9e53e8761
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/symfony/dependency-injection/zipball/900da8a42eceeb4a13a0ec34caa7db49328daff3
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/symfony/deprecation-contracts/zipball/63afe740e99a13ba87ec199bb07bbdee937a5b62
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/symfony/event-dispatcher-contracts/zipball/59eb412e93815df44f05f342958efa9f46b1e586
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/symfony/event-dispatcher/zipball/b0cf3162020603587363f0551cd3be43958611ff
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/symfony/filesystem/zipball/441c6b69f7222aadae7cbf5df588496d5ee37789
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/symfony/finder/zipball/a1b6aa435d2fba50793b994a839c32b6064f063b
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/symfony/http-foundation/zipball/b03d11e015552a315714c127d8d1e0f9e970ec88
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/symfony/mime/zipball/664d5e844a2de5e11c8255d0aef6bc15a9660ac7
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/symfony/options-resolver/zipball/eeaa8cabe54c7b3516938c72a4a161c0cc80a34f
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/symfony/polyfill-php83/zipball/17f6f9a6b1735c0f163024d959f700cfbc5155e5
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/symfony/polyfill-php84/zipball/d8ced4d875142b6a7426000426b8abc631d6b191
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/symfony/process/zipball/48bad913268c8cafabbf7034b39c8bb24fbc5ab8
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/symfony/service-contracts/zipball/45112560a3ba2d715666a509a0bc9521d10b6c43
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/symfony/stopwatch/zipball/b67e94e06a05d9572c2fa354483b3e13e3cb1898
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/symfony/string/zipball/50590a057841fa6bf69d12eceffce3465b9e32cb
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/symfony/translation-contracts/zipball/65a8bc82080447fae78373aa10f8d13b38338977
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/symfony/translation/zipball/300b72643e89de0734d99a9e3f8494a3ef6936e1
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/symfony/var-dumper/zipball/c6cd92486e9fc32506370822c57bc02353a5a92c
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/symfony/var-exporter/zipball/4ff50a1b7c75d1d596aca50899d0c8c7e3de8358
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/thecodingmachine/safe/zipball/2cdd579eeaa2e78e51c7509b50cc9fb89a956236
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/theofidry/cpu-core-counter/zipball/db9508f7b1474469d9d3c53b86f817e344732678
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)
https://api.github.com/repos/voku/portable-ascii/zipball/b1d923f88091c6bf09699efcd7c8a1b1bfd7351d
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kofh8I /usr/bin/composer install --quiet (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

This section details on the original issue you should resolve

<issue_title>[BUG] Swatches malfunction when "-- Please Select --" is explicitly chosen for listing attribute</issue_title>
<issue_description>### Is there an existing issue for this?

I have searched the existing issues

Current Behavior

Prerequisites

PR Fix: Decouple product detail swatches from listing attribute requirement #5137 must be merged first (decouples product detail swatches from listing attribute requirement)

When "Product Attribute to Use for Swatches in Product Listing" is explicitly set to "-- Please Select --" (empty selection), swatches display on the product detail page but don't function when clicked. The hidden select value doesn't update, causing "Please specify the product's option(s)" error on add to cart.

Expected Behavior

The explicit selection of "-- Please Select --" should behave the same as having no listing attribute configured. Product detail swatches should function independently.

Steps To Reproduce

Enable Configurable Swatches

Set "Product Attributes to Show as Swatches in Product Detail" to an attribute (e.g., Size)

Explicitly set "Product Attribute to Use for Swatches in Product Listing" to "-- Please Select --"

View configurable product page

Click a swatch option

Click "Add to Cart"

Error: "Please specify the product's option(s)"

Environment
- OpenMage: latest
- php: 8.4
Anything else?

Workaround

Select any attribute (even unused) in the listing field instead of "-- Please Select --".

Technical Notes

The issue is specific to the empty string value when "-- Please Select --" is chosen, versus null/undefined when the field is left unconfigured. Related to getSwatchAttributeId() handling in Helper/Productlist.php.</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes [BUG] Swatches malfunction when "-- Please Select --" is explicitly chosen for listing attribute #5186

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: addison74 <[email protected]>

sonarqubecloud · 2025-12-22T22:28:00Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2025-12-22T22:37:55Z

Test Results

966 tests ±0 958 ✅ ±0 16s ⏱️ ±0s
213 suites ±0 8 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 2f4276f. ± Comparison against base commit b74526a.

github-actions · 2025-12-22T22:37:55Z

Test Results

966 tests ±0 958 ✅ ±0 15s ⏱️ -1s
213 suites ±0 8 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 2f4276f. ± Comparison against base commit b74526a.

github-actions · 2025-12-22T22:37:56Z

Test Results

966 tests ±0 958 ✅ ±0 16s ⏱️ ±0s
213 suites ±0 8 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 2f4276f. ± Comparison against base commit b74526a.

♻️ This comment has been updated with latest results.

Initial plan

b1bae30

Copilot AI assigned Copilot and addison74 Dec 22, 2025

Copilot started work on behalf of addison74 December 22, 2025 22:07 View session

Decouple product detail swatches from listing attribute requirement

e982dec

Co-authored-by: addison74 <[email protected]>

github-actions bot added the Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches label Dec 22, 2025

Add clarifying comment about bypassing parent class check

2f4276f

Co-authored-by: addison74 <[email protected]>

Copilot AI changed the title ~~[WIP] Fix swatches malfunction with empty listing attribute~~ Fix product detail swatches when listing attribute is "-- Please Select --" Dec 22, 2025

Copilot AI requested a review from addison74 December 22, 2025 22:22

Copilot finished work on behalf of addison74 December 22, 2025 22:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix product detail swatches when listing attribute is "-- Please Select --" #5187

Fix product detail swatches when listing attribute is "-- Please Select --" #5187

Copilot AI commented Dec 22, 2025 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Dec 22, 2025

Uh oh!

github-actions bot commented Dec 22, 2025

Uh oh!

github-actions bot commented Dec 22, 2025

Uh oh!

github-actions bot commented Dec 22, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Fix product detail swatches when listing attribute is "-- Please Select --" #5187

Are you sure you want to change the base?

Fix product detail swatches when listing attribute is "-- Please Select --" #5187

Conversation

Copilot AI commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

I tried to connect to the following addresses, but was blocked by firewall rules:

Current Behavior

Prerequisites

Expected Behavior

Steps To Reproduce

Environment

Anything else?

Workaround

Technical Notes

Comments on the Issue (you are @copilot in this section)

Uh oh!

sonarqubecloud bot commented Dec 22, 2025

Quality Gate passed

Uh oh!

github-actions bot commented Dec 22, 2025

Test Results

Uh oh!

github-actions bot commented Dec 22, 2025

Test Results

Uh oh!

github-actions bot commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Dec 22, 2025 •

edited

Loading

github-actions bot commented Dec 22, 2025 •

edited

Loading