Fix install wizard #5190
Merged
Fix install wizard #5190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the install wizard by properly detecting whether the installation has been completed. The key issue was that the installation check didn't account for the temporary placeholder date value ('d-d-d-d-d') that is set in local.xml during the installation process.
Key Changes:
- Extracts the installation date to a variable for improved readability
- Adds an explicit check to exclude the temporary install date placeholder before determining if installation is complete
- Refactors the date validation logic into multiple clear conditions
Contributor
addison74
approved these changes
Dec 29, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issues (if relevant)