-
-
Notifications
You must be signed in to change notification settings - Fork 450
Fix relative patch path for magento-ecg/coding-standard #5215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: addison74 <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a bug where the ECG-72 patch used a relative path that fails when openmage/magento-lts is installed as a dependency in other projects. Per composer-patches documentation, relative paths in dependencies resolve from the consumer's root, not the package root.
- Changed ECG-72 patch path from relative (
.vendor-patches/ECG-72.patch) to absolute GitHub URL - Updated patches.lock.json to reflect the new URL and recalculated configuration hash
- Ensured consistency with all other patches which already use absolute GitHub URLs
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| composer.json | Updated ECG-72 patch URL from relative path to absolute GitHub URL matching the pattern of other patches |
| patches.lock.json | Updated patch URL and recalculated _hash to reflect composer.json changes |
| composer.lock | Updated content-hash as expected when composer.json changes |
|
You can merge too. |



The ECG-72 patch was using a relative path (
.vendor-patches/ECG-72.patch), which fails when openmage/magento-lts is installed as a dependency. Per composer-patches documentation, relative paths in dependencies resolve from the consumer's root, not the package root.Changes
All patches now use absolute URLs like:
"https://raw.githubusercontent.com/OpenMage/magento-lts/de83e28a673e3c1a249b51433abf6dc93e59063c/.vendor-patches/ECG-72.patch"Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/cweagans/composer-configurable-plugin/zipball/15433906511a108a1806710e988629fd24b89974/usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/2T31Pm /usr/bin/composer update --lock(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.