Skip to content

Remove unnecessary GROUP BY clause #5216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loekvangool wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove unnecessary GROUP BY clause #5216

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1abd076
Remove unnecessary GROUP BY clause
loekvangool Jan 5, 2026
37b3cb2
Fix parameter annotation in getProductCount method
loekvangool Jan 6, 2026
dea9d8b
Clean up docblock for getProductCount method
loekvangool Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions app/code/core/Mage/Catalog/Model/Resource/Category/Flat.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1233,19 +1233,15 @@ public function getChildrenAmount($category, $isActiveFlag = true)

/**
* Get products count in category
*
* @param Mage_Catalog_Model_Category $category
* @return int
*/
public function getProductCount($category)
public function getProductCount(Mage_Catalog_Model_Category $category): int
{
$select = $this->_getReadAdapter()->select()
->from(
$this->getTable('catalog/category_product'),
"COUNT({$this->getTable('catalog/category_product')}.product_id)",
)
->where("{$this->getTable('catalog/category_product')}.category_id = ?", $category->getId())
->group("{$this->getTable('catalog/category_product')}.category_id");
->where("{$this->getTable('catalog/category_product')}.category_id = ?", $category->getId());
return (int) $this->_getReadAdapter()->fetchOne($select);
}

Expand Down
Loading