[Captcha] Fix missing setWidth/setHeight with Captcha/Zend

[Hanmac]

Description (*)

The Size used in the Template:

magento-lts/app/design/frontend/base/default/layout/captcha.xml

Lines 19 to 21 in 533b2a7

	<action method="setFormId"><formId>user_login</formId></action>
	<action method="setImgWidth"><width>230</width></action>
	<action method="setImgHeight"><width>50</width></action>

was copied from captcha/captcha to captcha/zend in this:

magento-lts/app/code/core/Mage/Captcha/Block/Captcha.php

Lines 27 to 29 in 533b2a7

	$blockPath = Mage::helper('captcha')->getCaptcha($this->getFormId())->getBlockName();
	$block = $this->getLayout()->createBlock($blockPath);
	$block->setData($this->getData());

But the underlying Model, Mage_Captcha_Model_Zend setWidth and setHeight was never called.

Only used in the Template:

magento-lts/app/design/adminhtml/default/default/template/captcha/zend.phtml

Line 23 in 533b2a7

<img id="<?php echo $this->getFormId() ?>" width="<?php echo $this->getImgWidth() ?>" height="<?php echo $this->getImgHeight() ?>" src="<?php echo $captcha->getImgSrc() ?>" />

In frontend only using Height:

magento-lts/app/design/frontend/base/default/template/captcha/zend.phtml

Line 22 in 533b2a7

<img id="<?php echo $this->getFormId() ?>" class="captcha-img" height="<?php echo $this->getImgHeight() ?>" src="<?php echo $captcha->getImgSrc() ?>"/>

One of the other Problems, like overwriting the Template, but that might be fixed later.

Related Pull Requests

• see OpenMage/magento-lts#<issue_number>

Fixed Issues (if relevant)

• fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Test Results

966 tests  ±0   958 ✅ ±0   16s ⏱️ ±0s
213 suites ±0     8 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 7548a32. ± Comparison against base commit 533b2a7.

♻️ This comment has been updated with latest results.

[addison74]

Good catch!