Media Gallery behavior when duplicating a product: use copied images

[m-michalis]

This is the 3rd PR based on @addison74's #5026 (comment)

Parts:

• Keep/Skip product images (this pr): Ask whether to keep or skip product images on "Duplicate" + configuration for automating this behavior Media Gallery behavior when duplicating a product: Keep/Skip product images #5083
• Delete product/images: Whether to physically delete images on either when removing images from a product and/or deleting a product + configuration for default behavior. Media Gallery behavior when product is deleted or image removed from media gallery: Delete from filesystem #5224
• [This PR] Use new copied images: Copy and actually use copied images on new duplicated product (bug for many years) + propagate store values correctly regarding media attributes (image, small_image, thumbnail etc).

Description

Fixes a long-standing issue in the product duplication workflow where product image files were physically copied but not associated with the duplicated product.

This change decouples the image copy logic in

magento-lts/app/code/core/Mage/Catalog/Model/Product/Attribute/Backend/Media.php

Line 96 in 46a1093

public function beforeSave($object)

and executes it as a dedicated step after the product has been successfully duplicated:

magento-lts/app/code/core/Mage/Catalog/Model/Product.php

Lines 1463 to 1466 in 46a1093

	$this->getResource()
	->setSkipImagesOnDuplicate($newProduct->getSkipImagesOnDuplicate())
	->duplicate($this->getId(), $newProduct->getId());

• Image files are correctly assigned to duplicated products
• No orphaned image files are created during product duplication
• Product duplication behavior is more predictable and easier to maintain

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[addison74]

This PR is well elaborated and implemented. Thank you @m-michalis for your contribution.

I kindly ask those who have some time available to test and get it ready for 2.17.0.