Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 10, 2026

Follow-up to PR #5083 addressing grammatical precision and UI clarity issues in the product image duplication configuration section.

Changes

  • Label: Copy Images on DuplicateDuplicate Product Images

    • Avoids UI redundancy where "Duplicate" appears twice in context
    • Better represents behavior control vs. explicit copy action
  • Comment: Improved grammatical accuracy and clarity

    • Fixed: 'Ask' option only affects Admin interface. Default for programmatical duplication is to persist images.
    • To: The "Ask" option only applies to the Admin interface. By default, programmatic duplication preserves images.
    • Corrections: "programmatical" → "programmatic", "affects" → "applies"

Files Modified

  • app/code/core/Mage/Catalog/etc/system.xml - Configuration definition
  • app/locale/en_US/Mage_Adminhtml.csv - Translation entries

Configuration path: System > Configuration > Catalog > Product Image > Duplicate Product Images

Original prompt

This section details on the original issue you should resolve

<issue_title>[BUG] Follow-up the PR #5083: Review and refine text and labels related to section config</issue_title>
<issue_description>### Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

This report is related to this PR #5083.

  1. Comment in Config Section:
  • 'Ask' option only affects Admin interface. Default for programmatical duplication is to persist images
  • The phrasing is functional but lacks grammatical precision and clarity.
  1. Dropdown Label:
  • Label reads Copy Images on Duplicate.
  • This misrepresents the feature as a "copy" action instead of its true purpose—handling image duplication behavior.

Expected Behavior

  1. Comment Correction:
  • The “Ask” option only applies to the Admin interface and appears there exclusively. By default, programmatic duplication preserves images.
  • Why it's beneficial: This new phrasing ensures grammatical accuracy, provides clarity in meaning, and avoids ambiguity regarding the functionality.
  1. Dropdown Label:
  • Change to Duplicate Product Images.
  • Why it's beneficial:
    • Accurately conveys that the dropdown controls behavior during product duplication, not an explicit copying action.
    • Prevents redundancy and visual awkwardness created by Duplicate Duplicate appearing in the context of the dropdown options.

Steps To Reproduce

  1. Navigate to System > Configuration > Catalog > Product Image.
  2. Observe the comment displayed and the dropdown label.
  3. The terms do not align grammatically or contextually with intended functionality.

Environment

- OpenMage: latest from repository
- PHP: 8.4
- Test environment: Ubuntu + DDEV

Anything else?

Dropdown comment:

<?php $this->__('The “Ask” option only applies to the Admin interface. By default, programmatic duplication preserves images.') ?>

Dropdown Label:

<?php $this->__('Duplicate Product Images') ?>

These refinements will improve clarity and align the UI/UX with user expectations.</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

- Change label from "Copy Images on Duplicate" to "Duplicate Product Images"
- Improve comment text for better clarity and grammar
- Update corresponding translations in en_US/Mage_Adminhtml.csv

Co-authored-by: addison74 <[email protected]>
@sonarqubecloud
Copy link

Copilot AI changed the title [WIP] Fix text and labels in section config Refine text and labels for product image duplication config (Follow-up to PR #5083) Jan 10, 2026
Copilot AI requested a review from addison74 January 10, 2026 12:46
@github-actions github-actions bot added Component: Catalog Relates to Mage_Catalog translations Relates to app/locale labels Jan 10, 2026
@addison74 addison74 marked this pull request as ready for review January 10, 2026 13:02
Copilot AI review requested due to automatic review settings January 10, 2026 13:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refines the text and labels for the product image duplication configuration section following PR #5083. It improves grammatical precision and UI clarity for the configuration option that controls image handling during product duplication.

Changes:

  • Updated label from "Copy Images on Duplicate" to "Duplicate Product Images" for better clarity and to avoid UI redundancy
  • Improved comment text grammar and clarity, fixing "programmatical" to "programmatic" and enhancing overall readability

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
app/locale/en_US/Mage_Adminhtml.csv Updated translation entries for the label and comment text with improved grammar and clarity
app/code/core/Mage/Catalog/etc/system.xml Updated configuration label and comment to reference the new translation entries

@addison74
Copy link
Contributor

It is great you used double quotes (“Ask”) to refer to the actual dropdown option in the UI, following Magento/OpenMage conventions for comments. The word "preserves” is used instead of “persists” because it describes the user-facing behavior - existing images remain unchanged, rather than a technical implementation detail.

Here is the visual implementation

implementation

@addison74 addison74 requested review from Hanmac and theroch January 15, 2026 20:17
@Hanmac Hanmac requested a review from sreichel January 15, 2026 20:19
@addison74 addison74 merged commit d12d822 into main Jan 16, 2026
36 checks passed
@addison74 addison74 added this to the 20.17.0 milestone Jan 16, 2026
@addison74 addison74 deleted the copilot/fix-text-labels-section-config branch January 16, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Catalog Relates to Mage_Catalog translations Relates to app/locale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Follow-up the PR #5083: Review and refine text and labels related to section config

4 participants