Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 23, 2026

Buttons in the order creation customer selection view render with no spacing between them.

Changes

Added CSS rule to apply 5px left margin to subsequent buttons within .entry-edit-head:

.entry-edit .entry-edit-head button:not(:first-child) {
  margin: 0 0 0 5px;
}

Screenshot

Before:

After:

Files Modified

  • skin/adminhtml/openmage/default/scss/override.scss - Added button spacing rule
  • skin/adminhtml/openmage/default/override.css - Compiled output
  • skin/adminhtml/openmage/default/override.css.map - Updated source map

Note

This PR has been rebased on main to resolve conflicts with PR #4756, which reorganized the admin theme structure (moving files from skin/adminhtml/default/openmage/ to skin/adminhtml/openmage/default/). The button spacing fix is now in the correct location.

Original prompt

This section details on the original issue you should resolve

<issue_title>[BUG] Create new order buttons without margin</issue_title>
<issue_description>### Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Between the button Create new customer and Create Guest Order exists no space

Image

Expected Behavior

Space between buttons

Steps To Reproduce

  1. Login to Backend
  2. Create new order

Environment

- OpenMage: 20.16.0
- php: 8.2

Anything else?

Possible solution maybe margin: 0 0 0 5px; like in the order edit form?</issue_description>

Comments on the Issue (you are @copilot in this section)

@theroch The [PR 2233](https://github.com//pull/2233) was tested against the legacy design.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: addison74 <8360474+addison74@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix margin between create new order buttons Add spacing between buttons in Create New Order page Jan 23, 2026
Copilot AI requested a review from addison74 January 23, 2026 16:17
@github-actions github-actions bot added Template : admin Relates to admin template Component: Adminhtml Relates to Mage_Adminhtml labels Jan 23, 2026
@addison74 addison74 marked this pull request as ready for review January 23, 2026 16:22
@addison74 addison74 requested review from Copilot and theroch January 23, 2026 16:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds consistent spacing between buttons in the Create New Order customer selection view by applying a 5px left margin to subsequent buttons within .entry-edit-head.

Changes:

  • Added CSS rule to apply 5px left margin to buttons (excluding the first) within .entry-edit-head sections

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
skin/adminhtml/default/openmage/scss/override.scss Added SCSS rule for button spacing in entry-edit-head sections
skin/adminhtml/default/openmage/override.css Compiled CSS output with the new button spacing rule
skin/adminhtml/default/openmage/override.css.map Updated source map reflecting the SCSS changes

Hanmac and others added 2 commits January 26, 2026 20:05
* Fix #1216 and the fallback theme

* ~ copilot hints

* Clean cache on update

Signed-off-by: Frank Rochlitzer <f.rochlitzer@b3-it.de>

* Update app/code/core/Mage/Core/Model/Layout/Update.php

Add @param Mage_Core_Model_Config_Element $updates and @return Mage_Core_Model_Config_Element to improve API documentation.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update app/code/core/Mage/Core/Model/Design/Fallback.php

Explanation for array manipulation

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* ~ cs-fixer

* Rector fix - Clean up docblock in addFallbackThemesLayoutUpdates

Removed unnecessary docblock comments from the method.

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* ~rector

---------

Signed-off-by: Frank Rochlitzer <f.rochlitzer@b3-it.de>
Co-authored-by: Frank Rochlitzer <f.rochlitzer@b3-it.de>
Co-authored-by: Frank Rochlitzer <theroch@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Addison <8360474+addison74@users.noreply.github.com>
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
13.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@github-actions github-actions bot added Component: PayPal Relates to Mage_Paypal Component: Core Relates to Mage_Core Component: Catalog Relates to Mage_Catalog Component: Cms Relates to Mage_Cms Component: Reports Relates to Mage_Reports Component: AdminNotification Relates to Mage_AdminNotification Component: Sales Relates to Mage_Sales Component: Usa Relates to Mage_Usa Component: Customer Relates to Mage_Customer Component: Eav Relates to Mage_Eav labels Jan 26, 2026
@github-actions github-actions bot added Component: Captcha Relates to Mage_Captcha Component: Tag Relates to Mage_Tag Component: CurrencySymbol Relates to Mage_CurrencySymbol Component: Admin Relates to Mage_Admin Component: Widget Relates to Mage_Widget Component: Weee Relates to Mage_Weee Component: Tax Relates to Mage_Tax Component: Review Relates to Mage_Review Component: Rating Relates to Mage_Rating Component: Payment Relates to Mage_Payment Component: Oauth Relates to Mage_Oauth Component: Newsletter Relates to Mage_Newsletter Component: Index Relates to Mage_Index Component: Giftmessage Relates to Mage_Giftmessage Component: Downloadable Relates to Mage_Downloadable Component: Bundle Relates to Mage_Bundle Component: Api2 Relates to Mage_Api2 Component: Media Relates to Mage_Media Component: ImportExport Relates to Mage_ImportExport Component: Directory Relates to Mage_Directory Component: CatalogSearch Relates to Mage_CatalogSearch Component: Authorizenet Relates to Mage_Authorizenet Component: Centinel Relates to Mage_Centinel Component: Dataflow Relates to Mage_Dataflow Component: Rss Relates to Mage_Rss Component: Paygate Relates to Mage_Paygate phpstan labels Jan 26, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2026

Test Results

970 tests  ±0   962 ✅ ±0   20s ⏱️ +3s
214 suites ±0     8 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 2b26553. ± Comparison against base commit 674f9f9.

♻️ This comment has been updated with latest results.

@addison74 addison74 closed this Jan 27, 2026
@addison74 addison74 deleted the copilot/fix-button-margin-issue branch January 27, 2026 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Admin Relates to Mage_Admin Component: Adminhtml Relates to Mage_Adminhtml Component: AdminNotification Relates to Mage_AdminNotification Component: Api PageRelates to Mage_Api Component: Api2 Relates to Mage_Api2 Component: Authorizenet Relates to Mage_Authorizenet Component: Bundle Relates to Mage_Bundle Component: Captcha Relates to Mage_Captcha Component: Catalog Relates to Mage_Catalog Component: CatalogSearch Relates to Mage_CatalogSearch Component: Centinel Relates to Mage_Centinel Component: Cms Relates to Mage_Cms Component: Core Relates to Mage_Core Component: CurrencySymbol Relates to Mage_CurrencySymbol Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Directory Relates to Mage_Directory Component: Downloadable Relates to Mage_Downloadable Component: Eav Relates to Mage_Eav Component: Giftmessage Relates to Mage_Giftmessage Component: ImportExport Relates to Mage_ImportExport Component: Index Relates to Mage_Index Component: Media Relates to Mage_Media Component: Newsletter Relates to Mage_Newsletter Component: Oauth Relates to Mage_Oauth Component: Page Relates to Mage_Page Component: Paygate Relates to Mage_Paygate Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Component: Rating Relates to Mage_Rating Component: Reports Relates to Mage_Reports Component: Review Relates to Mage_Review Component: Rss Relates to Mage_Rss Component: Sales Relates to Mage_Sales Component: Tag Relates to Mage_Tag Component: Tax Relates to Mage_Tax Component: Usa Relates to Mage_Usa Component: Weee Relates to Mage_Weee Component: Widget Relates to Mage_Widget phpstan Template : admin Relates to admin template

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Create new order buttons without margin

3 participants