Support new PEP 600 tagging for Python wheels (#150)

* fix

* add ubuntu 20.04 to CD

* fix

.github/workflows/CD.yml

@@ -103,7 +103,7 @@ jobs:
     strategy:
       matrix:
         python-version: ['3.8', '3.9', '3.10']
-        os: [ubuntu-22.04, macos-12]
+        os: [ubuntu-22.04, ubuntu-20.04, macos-12]
     steps:
       - uses: actions/checkout@v3
       - name: Set up Python

CHANGES.md

@@ -1,3 +1,9 @@
+# Version 1.0.3
+
+Bugfix:
+
+- The Python builds were using the older `manylinux2014` tagging convention which was causing issues on systems that expected a specific glibc version (Ubuntu 20.04 uses [2.31](https://launchpad.net/ubuntu/+source/glibc)). We now use the latest `manylinux_x_y` tagging convention to accomodate different glibc versions across linux when building wheels. This means we must support `python 3.8.10+, 3.9.5+, 3.10.0+` and `pip >= 20.3` in accordance with [PEP 600](https://github.com/pypa/manylinux)
+
 # Version 1.0.2
 
 Feat:

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@openmined/psi.js",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "Private Set Intersection for JavaScript",
   "repository": {
     "type": "git",

private_set_intersection/python/BUILD

@@ -97,10 +97,10 @@ py_wheel(
         "@bazel_tools//src/conditions:windows_arm64": "win_arm64",
         "@bazel_tools//src/conditions:darwin_x86_64": "macosx_12_0_x86_64",
         "@bazel_tools//src/conditions:darwin_arm64": "macosx_12_0_arm64",
-        "@bazel_tools//src/conditions:linux_x86_64": "manylinux2014_x86_64",
-        "@bazel_tools//src/conditions:linux_aarch64": "manylinux2014_aarch64",
+        "@bazel_tools//src/conditions:linux_x86_64": "manylinux_GLIBC_x86_64",
+        "@bazel_tools//src/conditions:linux_aarch64": "manylinux_GLIBC_aarch64",
     }),
-    python_requires = ">=3.8",
+    python_requires = ">=3.8.10",  # Required for linux's wheel naming convention
     python_tag = "INTERPRETER",
     requires = ["protobuf>=3.20"],
     version = VERSION_LABEL,

private_set_intersection/python/rename.py

@@ -1,6 +1,6 @@
 # This file is used to rename the wheel generated via py_wheel with values
 # determined at runtime
-import sys, os, re
+import sys, os, re, platform
 from packaging import tags
 
 
@@ -21,6 +21,13 @@ def main():
     # INTERPRETER and ABI should be the same value
     outfile = re.sub(r"INTERPRETER", abi_tag, inputfile)
     outfile = re.sub(r"ABI", abi_tag, outfile)
+    system = platform.system()
+
+    # Rename the wheel depending on the version of glibc
+    if system.lower() == "linux":
+        version = platform.libc_ver()[1]
+        glibc_version = version.replace(".", "_")
+        outfile = re.sub(r"GLIBC", glibc_version, outfile)
 
     print("renaming ", inputfile, outfile)
     os.rename(inputfile, outfile)

tools/package.bzl

@@ -1,2 +1,2 @@
 """ Version of the current release """
-VERSION_LABEL = "1.0.2"
+VERSION_LABEL = "1.0.3"