Disable tests on publish and bump version #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvadym
commented
Oct 18, 2023
| @@ -177,11 +179,6 @@ jobs: | |||
| run: | | |||
| Get-ChildItem -Path ./ -Filter "*.whl" -Recurse -File | foreach {poetry run twine check $_.FullName} | |||
|
|
|||
| - name: Renaming wheel | |||
There was a problem hiding this comment.
No need to rename, it's already has a correct name with _manylinux
chinmayshah99
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current tests in publish should test the newly built wheel, but actually they run from
src/folder.Tests now fail because:
Before: on the running tests,
src/pydp/_pydp.sois used.Now: In the new build with
cibuildwheel, the build happens in Docker, sosrc/pydp/_pydp.sois not presentAnyway the tests don't test wheel, which they should test, let's for now disable them, to release a new RC candidate version and then let's fix later.