Merge backend and worker dockerfile #8240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiendang
force-pushed
the
remove-worker-dockerfile
branch
from
1bff400 to
a153f8b
Compare
kiendang
force-pushed
the
remove-worker-dockerfile
branch
from
a153f8b to
6fb1a7b
Compare
kiendang
changed the title
rasswanth-s
reviewed
Nov 21, 2023
rasswanth-s
reviewed
Nov 21, 2023
rasswanth-s
reviewed
Nov 21, 2023
| return SQLiteStoreConfig(client_config=client_config) | ||
|
|
||
|
|
||
| def seaweedfs_config() -> SeaweedFSConfig: |
There was a problem hiding this comment.
Good work, seggregating it into distinct functions , makes the code more readable.
rasswanth-s
reviewed
Nov 21, 2023
| store_config = sql_store_config() if single_container_mode else mongo_store_config() | ||
| blob_storage_config = None if single_container_mode else seaweedfs_config() | ||
|
|
||
| worker = worker_class( |
Co-authored-by: Shubham Gupta <[email protected]>
kiendang
force-pushed
the
remove-worker-dockerfile
branch
from
6fb1a7b to
c518578
Compare
kiendang
force-pushed
the
remove-worker-dockerfile
branch
from
518a215 to
1871d85
Compare
rasswanth-s
reviewed
Nov 21, 2023
rasswanth-s
reviewed
Nov 21, 2023
fixed orchestra outputs
rasswanth-s
approved these changes
Nov 21, 2023
shubham3121
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Checklist