Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force parse to string vars evaluated from github inputs #8649

Merged
merged 6 commits into from
Apr 2, 2024
Merged

force parse to string vars evaluated from github inputs #8649

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
990e681
force parse to string vars evaluated from github inpusts
shubham3121 Apr 1, 2024
ccbfb37
fix syntax
shubham3121 Apr 2, 2024
c4c851f
update syntax to use [[]]
shubham3121 Apr 2, 2024
1f31628
remove ; from pip install
shubham3121 Apr 2, 2024
3a5886a
fix syntax of installing syft with data_science
shubham3121 Apr 2, 2024
be0c135
update pip install syft with dev packages for unit tests workflow
shubham3121 Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/cd-post-release-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,10 @@ jobs:

- name: Install Syft
run: |
if (${{ inputs.release_platform }} == "REAL_PYPI"); then
if [ "${{ inputs.release_platform }}" == "REAL_PYPI" ]; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NITPICK: In shell commands singe square brackets work only -eq or = but only with double square brackets == operation works

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed using :c4c851f

pip install syft==${{ inputs.syft_version }}
fi
if (${{ inputs.release_platform }}" == "TEST_PYPI"); then
if [ "${{ inputs.release_platform }}" == "TEST_PYPI" ]; then
pip install -i https://test.pypi.org/simple/ syft==${{ inputs.syft_version }}
fi

Expand Down Expand Up @@ -282,10 +282,10 @@ jobs:
env:
SYFT_VERSION: ${{ inputs.syft_version }}
run: |
if [[ "${{ inputs.release_platform }}" == "TEST_PYPI" ]]; then
if ("${{ inputs.release_platform }}" == "TEST_PYPI"); then
pip install -i https://test.pypi.org/simple/ syft==${{ inputs.syft_version }}[data_science];
fi
if [[ "${{ inputs.release_platform }}" == "REAL_PYPI" ]]; then
if ("${{ inputs.release_platform }}" == "REAL_PYPI"); then
pip install syft==${{ inputs.syft_version }}[data_science];
fi

Expand Down
Loading