-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transformers from 4.39.3 to 4.41.2, Pandas from 2.2.1 to 2.2.2, Matplotlib from 3.8.3 to 3.9.0, Uvicorn from 0.27.1 to 0.30.0, Fastapi from 0.110.0 to 0.111.0, and Typing_extensions from 4.10.0 to 4.12.0 #8686
Conversation
Hi @Smartappli thanks for the PRs. We actually have some manual testing in Google Colab, we need to do before we can bump some packages. Sometimes these small lib changes cause incompatibility so I am hesitant to merge these without additional testing. You can do this by running this in Google Colab and then importing the library and making sure things work:
Let me know how you go and report back. |
Hi @madhavajay Thank you for your advising. I combined all the PRs into one and tested the installation on google colab as requested. It installs without error :) |
@Smartappli looks like the versions we install for The best way to handle this is to figure out what versions Colab has before we install and then add them to a lower range in Can you see if we can fix this? |
@madhavajay done |
@madhavajay @yashgorana I propose to migrate numpy to version 2.0.0 which will be released in two weeks in a separate PR in order to close this PR. What do you think? Related PR: #8875 |
@Smartappli yes I saw the release announcement. My main concern would be if it does break compatibility, I wonder how long others will wait to upgrade, for example google colab. It wouldn't hurt for us to get to a newer numpy for now just to keep the deprecation window moving. |
Description
Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Checklist