Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformers from 4.39.3 to 4.41.2, Pandas from 2.2.1 to 2.2.2, Matplotlib from 3.8.3 to 3.9.0, Uvicorn from 0.27.1 to 0.30.0, Fastapi from 0.110.0 to 0.111.0, and Typing_extensions from 4.10.0 to 4.12.0 #8686

Merged
merged 105 commits into from
Jun 3, 2024

Conversation

Smartappli
Copy link
Contributor

Description

Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

@Smartappli Smartappli marked this pull request as draft April 8, 2024 21:27
@Smartappli Smartappli marked this pull request as ready for review April 8, 2024 21:28
@Smartappli Smartappli marked this pull request as draft April 8, 2024 21:29
@Smartappli Smartappli changed the title Bump Jax from 0.4.20 to 0.4.26 Bump Jax from 0.4.20 to 0.4.26 & Torch from 2.2.1 to 2.2.2 Apr 10, 2024
@Smartappli Smartappli marked this pull request as ready for review April 10, 2024 20:11
@Smartappli Smartappli changed the title Bump Jax from 0.4.20 to 0.4.26 & Torch from 2.2.1 to 2.2.2 Bump Jax from 0.4.20 to 0.4.26, Torch from 2.2.1 to 2.2.2 & Pandas from 2.2.1 to 2.2.2 Apr 10, 2024
@madhavajay
Copy link
Collaborator

Hi @Smartappli thanks for the PRs. We actually have some manual testing in Google Colab, we need to do before we can bump some packages.

Sometimes these small lib changes cause incompatibility so I am hesitant to merge these without additional testing.

You can do this by running this in Google Colab and then importing the library and making sure things work:

!pip install 'git+https://github.com/YOURFORK/PySyft@YOUR_BRANCH#egg=syft&subdirectory=packages/syft'

Let me know how you go and report back.
Same would apply to the other PRs. You could combine these into one and test it together.

#8684
#8688

@Smartappli Smartappli changed the title Bump Jax from 0.4.20 to 0.4.26, Torch from 2.2.1 to 2.2.2 & Pandas from 2.2.1 to 2.2.2 Bump Jax from 0.4.20 to 0.4.26, Torch from 2.2.1 to 2.2.2, Pandas from 2.2.1 to 2.2.2, Matplotlib from 3.8.3 to 3.8.4 Apr 11, 2024
@Smartappli Smartappli changed the title Bump Jax from 0.4.20 to 0.4.26, Torch from 2.2.1 to 2.2.2, Pandas from 2.2.1 to 2.2.2, Matplotlib from 3.8.3 to 3.8.4 Bump Jax from 0.4.20 to 0.4.26, Torch from 2.2.1 to 2.2.2, Pandas from 2.2.1 to 2.2.2 & Matplotlib from 3.8.3 to 3.8.4 Apr 11, 2024
@Smartappli Smartappli changed the title Bump Jax from 0.4.20 to 0.4.26, Torch from 2.2.1 to 2.2.2, Pandas from 2.2.1 to 2.2.2 & Matplotlib from 3.8.3 to 3.8.4 Bump Jax from 0.4.20 to 0.4.26, Torch from 2.2.1 to 2.2.2, Pandas from 2.2.1 to 2.2.2 & Matplotlib from 3.8.3 to 3.8.4, Uvicorn from 0.27.1 to 0.29.0 & Fastapi from 0.110.0 to 0.110.1 Apr 11, 2024
@Smartappli
Copy link
Contributor Author

Smartappli commented Apr 11, 2024

Hi @Smartappli thanks for the PRs. We actually have some manual testing in Google Colab, we need to do before we can bump some packages.

Sometimes these small lib changes cause incompatibility so I am hesitant to merge these without additional testing.

You can do this by running this in Google Colab and then importing the library and making sure things work:

!pip install 'git+https://github.com/YOURFORK/PySyft@YOUR_BRANCH#egg=syft&subdirectory=packages/syft'

Let me know how you go and report back. Same would apply to the other PRs. You could combine these into one and test it together.

#8684 #8688

Hi @madhavajay

Thank you for your advising.

I combined all the PRs into one and tested the installation on google colab as requested. It installs without error :)

image

@madhavajay
Copy link
Collaborator

@Smartappli looks like the versions we install for [matplotlib,mpl_toolkits,numpy,psutil] are causing incompatibility requiring a session restart.
Screenshot 2024-04-15 at 10 35 13 pm

The best way to handle this is to figure out what versions Colab has before we install and then add them to a lower range in setup.cfg so that Colab is satisfied while people who install syft in a seperate fresh virtualenv elsewhere will get the latest versions.

Can you see if we can fix this?

@Smartappli
Copy link
Contributor Author

@madhavajay done

@Smartappli Smartappli changed the title Torch from 2.2.1 to 2.3.0, Transformers from 4.39.3 to 4.41.0, Pandas from 2.2.1 to 2.2.2, Tqdm from 4.66.2 to 4.66.4, Matplotlib from 3.8.3 to 3.9.0, Uvicorn from 0.27.1 to 0.29.0, Fastapi from 0.110.0 to 0.111.0, Networkx from 3.2.1 to 3.3, and Typing_extensions from 4.10.0 to 4.11.0 Transformers from 4.39.3 to 4.41.0, Pandas from 2.2.1 to 2.2.2, Matplotlib from 3.8.3 to 3.9.0, Uvicorn from 0.27.1 to 0.29.0, Fastapi from 0.110.0 to 0.111.0, Networkx from 3.2.1 to 3.3, and Typing_extensions from 4.10.0 to 4.11.0 May 24, 2024
@Smartappli Smartappli changed the title Transformers from 4.39.3 to 4.41.0, Pandas from 2.2.1 to 2.2.2, Matplotlib from 3.8.3 to 3.9.0, Uvicorn from 0.27.1 to 0.29.0, Fastapi from 0.110.0 to 0.111.0, Networkx from 3.2.1 to 3.3, and Typing_extensions from 4.10.0 to 4.11.0 Transformers from 4.39.3 to 4.41.0, Pandas from 2.2.1 to 2.2.2, Matplotlib from 3.8.3 to 3.9.0, Uvicorn from 0.27.1 to 0.30.0, Fastapi from 0.110.0 to 0.111.0, and Typing_extensions from 4.10.0 to 4.12.0 May 30, 2024
@Smartappli Smartappli changed the title Transformers from 4.39.3 to 4.41.0, Pandas from 2.2.1 to 2.2.2, Matplotlib from 3.8.3 to 3.9.0, Uvicorn from 0.27.1 to 0.30.0, Fastapi from 0.110.0 to 0.111.0, and Typing_extensions from 4.10.0 to 4.12.0 Transformers from 4.39.3 to 4.41.2, Pandas from 2.2.1 to 2.2.2, Matplotlib from 3.8.3 to 3.9.0, Uvicorn from 0.27.1 to 0.30.0, Fastapi from 0.110.0 to 0.111.0, and Typing_extensions from 4.10.0 to 4.12.0 May 30, 2024
@Smartappli
Copy link
Contributor Author

Smartappli commented May 30, 2024

@madhavajay @yashgorana I propose to migrate numpy to version 2.0.0 which will be released in two weeks in a separate PR in order to close this PR. What do you think?

Related PR: #8875

@madhavajay
Copy link
Collaborator

@Smartappli yes I saw the release announcement. My main concern would be if it does break compatibility, I wonder how long others will wait to upgrade, for example google colab. It wouldn't hurt for us to get to a newer numpy for now just to keep the deprecation window moving.

@madhavajay madhavajay merged commit 9635911 into OpenMined:dev Jun 3, 2024
23 checks passed
@Smartappli Smartappli deleted the jax branch June 3, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants