Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Action Graph Service #8825

Merged
merged 14 commits into from
May 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ repos:
name: "mypy: syft"
always_run: true
files: "^packages/syft/src/syft/"
exclude: "packages/syft/src/syft/types/dicttuple.py|^packages/syft/src/syft/service/action/action_graph.py"
exclude: "packages/syft/src/syft/types/dicttuple.py"
args: [
"--follow-imports=skip",
"--ignore-missing-imports",
Expand Down
97 changes: 0 additions & 97 deletions notebooks/tutorials/data-scientist/04-action-graph.ipynb

This file was deleted.

1 change: 0 additions & 1 deletion packages/syft/setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ syft =
boto3==1.34.56
forbiddenfruit==0.1.4
loguru==0.7.2
networkx==3.2.1
packaging>=23.0
pyarrow==15.0.0
# pycapnp is beta version, update to stable version when available
Expand Down
20 changes: 0 additions & 20 deletions packages/syft/src/syft/serde/third_party.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@
from dateutil import parser
from nacl.signing import SigningKey
from nacl.signing import VerifyKey
import networkx as nx
from networkx import DiGraph
import numpy as np
from pandas import DataFrame
from pandas import Series
Expand Down Expand Up @@ -229,24 +227,6 @@ def torch_deserialize(buffer: bytes) -> torch.tensor:
# how else do you import a relative file to execute it?
NOTHING = None


# TODO: debug serializing after updating a node
def serialize_networkx_graph(graph: DiGraph) -> bytes:
graph_dict: dict = nx.node_link_data(graph)
return serialize(graph_dict, to_bytes=True)


def deserialize_networkx_graph(buf: bytes) -> DiGraph:
graph_dict: dict = deserialize(buf, from_bytes=True)
return nx.node_link_graph(graph_dict)


recursive_serde_register(
DiGraph,
serialize=serialize_networkx_graph,
deserialize=deserialize_networkx_graph,
)

try:
# Just register these serializers if the google.cloud.bigquery & db_dtypes module are available
# third party
Expand Down
Loading
Loading