Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DX] print out SQLite database path in dev mode #8830

Merged
merged 4 commits into from
May 21, 2024
Merged

[DX] print out SQLite database path in dev mode #8830

merged 4 commits into from
May 21, 2024

Conversation

khoaguin
Copy link
Member

@khoaguin
Copy link
Member Author

For now we are printing 2 paths (one for document_store, and one for action_store)
image

@khoaguin khoaguin requested a review from shubham3121 May 17, 2024 03:05
@khoaguin khoaguin self-assigned this May 17, 2024
@shubham3121
Copy link
Member

shubham3121 commented May 20, 2024 •
edited
Loading

@khoaguin possible to indicate in the prints which db is mapped to which Store

@khoaguin
Copy link
Member Author

Thanks @shubham3121 for the feed back. Updated accordingly

image

shubham3121
shubham3121 approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@shubham3121 shubham3121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@shubham3121 shubham3121 enabled auto-merge May 21, 2024 07:22
@shubham3121 shubham3121 merged commit 20dd090 into OpenMined:dev May 21, 2024
23 checks passed
@khoaguin khoaguin deleted the show-SQLite-db-path-dev-mode branch May 21, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham3121 shubham3121 shubham3121 approved these changes

Assignees

@khoaguin khoaguin

Labels
Yellow Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khoaguin @shubham3121