Remove Hagrid #8835
Merged
Remove Hagrid #8835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasswanth-s
requested review from
yashgorana and
madhavajay
and removed request for
yashgorana
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
rasswanth-s
requested review from
shubham3121,
yashgorana,
madhavajay,
snwagh and
itstauq
and removed request for
madhavajay
snwagh
approved these changes
May 17, 2024
There was a problem hiding this comment.
I would love to learn best practices in reviewing such a PR. I checked the github actions testing, code browsing for hagrid references but would love to learn tricks and best practices for going about this.
There are some documentation related changes that might need to happen or deprecating outdated notebook tutorials but nothing that I noticed on the code side so approving the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR aims to remove Hagrid, as it is deprecated.
Before this PR, there were several PR's raised to add/refactor functionalities as hagrid is to be removed.
Currently the newly available deployment types are mentioned here:
Deployments
Affected Dependencies
Hagrid
How has this been tested?
Existing Tests
Checklist