Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Jax and Haiku #8837

Merged
merged 14 commits into from
May 24, 2024
Merged

Remove Jax and Haiku #8837

merged 14 commits into from
May 24, 2024

Conversation

khoaguin
Copy link
Member

@khoaguin khoaguin commented May 20, 2024

Description

Since Haiku is deprecated, we should remove Jax and update the notebooks where Jax is used to use Torch

Link to Issue

Affected Dependencies

  • Removed:
jaxlib==0.4.20
jax==0.4.20
dm-haiku==0.0.10

Notebook Changes

The 5th notebook in notebooks/api and the 4 notebooks in notebooks/tutorials/models_training/ are modified to use torch instead of jax and haiku

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@khoaguin khoaguin self-assigned this May 20, 2024
@khoaguin khoaguin requested a review from shubham3121 May 20, 2024 09:53
@khoaguin khoaguin force-pushed the remove-jax-haiku branch from 19c7115 to 6945153 Compare May 22, 2024 01:54
Copy link
Member

@shubham3121 shubham3121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @khoaguin as always !! 💯 🎉


try:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the kind words @shubham3121

@khoaguin khoaguin merged commit 870456b into OpenMined:dev May 24, 2024
23 checks passed
@khoaguin khoaguin deleted the remove-jax-haiku branch May 24, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants