Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix justfile & reset_k8s script #9305

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Fix justfile & reset_k8s script #9305

merged 4 commits into from
Sep 20, 2024

Conversation

yashgorana
Copy link
Contributor

@yashgorana yashgorana commented Sep 19, 2024 •
edited
Loading

Description

Add some perf improvements to delete & reset scripts.

Closes https://github.com/OpenMined/Heartbeat/issues/1841

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

@yashgorana yashgorana mentioned this pull request Sep 20, 2024
Closed
4 tasks
shubham3121
shubham3121 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@shubham3121 shubham3121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! 💯

@yashgorana yashgorana merged commit 5c09f0a into dev Sep 20, 2024
38 checks passed
@yashgorana yashgorana deleted the yash/fix-justfile branch September 20, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham3121 shubham3121 shubham3121 approved these changes

@rasswanth-s rasswanth-s Awaiting requested review from rasswanth-s

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yashgorana @shubham3121