Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more testing coverage for L0 (multiple requests, email server) #9306

Merged
merged 29 commits into from
Sep 25, 2024

Conversation

BrendanSchell
Copy link
Contributor

@BrendanSchell BrendanSchell commented Sep 19, 2024

Description

Updates sync bigquery notebooks to be more consistent with L2 notebooks.

Added:

  • Multiple users being added / requests being made
  • SMTP server added and checks that emails sent correctly for requests, job failures
  • Miscellaneous cleanup

Buries in the grave: https://github.com/OpenMined/Heartbeat/issues/1834#event-14290292846

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@BrendanSchell BrendanSchell force-pushed the bschell/l0-add-more-testing-coverage branch from a97c604 to 695e376 Compare September 20, 2024 22:07
@snwagh snwagh mentioned this pull request Sep 23, 2024
@BrendanSchell BrendanSchell force-pushed the bschell/l0-add-more-testing-coverage branch from 695e376 to b7a16af Compare September 23, 2024 15:40
@BrendanSchell BrendanSchell force-pushed the bschell/l0-add-more-testing-coverage branch 2 times, most recently from a07b8f3 to e173012 Compare September 24, 2024 17:39
@BrendanSchell BrendanSchell force-pushed the bschell/l0-add-more-testing-coverage branch from e5cc79a to cef12a1 Compare September 25, 2024 15:11
@snwagh snwagh changed the title [WIP] Add more testing coverage for L0 (multiple requests, auto-approval) Add more testing coverage for L0 (multiple requests, auto-approval) Sep 25, 2024
@BrendanSchell BrendanSchell changed the title Add more testing coverage for L0 (multiple requests, auto-approval) Add more testing coverage for L0 (multiple requests) Sep 25, 2024
@BrendanSchell BrendanSchell changed the title Add more testing coverage for L0 (multiple requests) Add more testing coverage for L0 (multiple requests, email server) Sep 25, 2024
@BrendanSchell BrendanSchell marked this pull request as ready for review September 25, 2024 19:22
@snwagh snwagh self-requested a review September 25, 2024 19:30
@IonesioJunior IonesioJunior merged commit bd72687 into dev Sep 25, 2024
39 checks passed
@IonesioJunior IonesioJunior deleted the bschell/l0-add-more-testing-coverage branch September 25, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants