goca: parse HostShare Datastores struct from HostXML.cc #6284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjoy
commented
Jul 26, 2023
|
|
||
| type Datastore struct { | ||
| ID int `xml:"ID,omitempty"` | ||
| TotalMB int `xml:"TOTAL_MB,omitempty"` |
There was a problem hiding this comment.
Same as in
one/src/oca/go/src/goca/schemas/datastore/datastore.go
Lines 49 to 51 in 08bb8f7
Signed-off-by: William Wei <[email protected]>
paczerny
approved these changes
Oct 4, 2023
| FreeDisk int `xml:"FREE_DISK,omitempty"` | ||
| MaxDisk int `xml:"MAX_DISK,omitempty"` | ||
| UsedDisk int `xml:"USED_DISK,omitempty"` | ||
| Datastore Datastore `xml:"DS,omitempty"` |
There was a problem hiding this comment.
The Host can have more then one datastore, so this line should be an array
Datastores []Datastore `xml:"DS,omitempty"`
|
THANKS for the contribution. This has been merged as per 45a8543 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow parse extra data generated from:
one/src/scheduler/src/pool/HostXML.cc
Lines 62 to 68 in 08bb8f7