feat: github users table #208
Conversation
| * @param { import("knex").Knex } knex | ||
| * @returns { Promise<void> } | ||
| */ | ||
| exports.up = async (knex) => { |
There was a problem hiding this comment.
This table is being created with the response from https://docs.github.com/en/rest/orgs/members?apiVersion=2022-11-28#list-organization-members, I think it makes the most sense. I don't think we need all the user information.
bjohansebas
force-pushed
the
github_users
branch
from
0903448 to
78b45de
Compare
There was a problem hiding this comment.
This was brought from the schema provided by GitHub
| for await (const org of organizations) { | ||
| debug(`Fetching members for org (${org.login})`) | ||
| logger.info(`Fetching members for org (${org.login})`) | ||
| const members = await github.fetchOrgMembersByLogin(org.login) | ||
| debug(`Got ${members.length} members for org: ${org.login}`) | ||
| debug('Validating data') | ||
| validateGithubListOrgMembers(members) | ||
|
|
||
| // Upsert each member in parallel | ||
| for await (const member of members) { | ||
| debug(`Upserting member (${member.login})`) | ||
| const mappedData = github.mappers.user(member) | ||
| await upsertGithubMembers(mappedData) | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This process needs to be as synchronous as possible due to potential latency since there may be multiple users in different organizations, as is the case with Express. This could cause errors when inserting.
|
I think the best option would be to split this PR into two: one for GitHub users and another for roles. @UlisesGascon What do you think? The roles topic has quite a bit of logic since there are roles by teams and by repository, at least that's what I understood from the GitHub API. |
|
Is there anything I can do to move this forward? |
1 participant
Related #148