Adding Feature of IPP Service Discoveries #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdohnal
requested changes
Oct 30, 2024
| @@ -2278,4 +2329,4 @@ def main(show_jobs): | |||
| if opt == "--embedded": | |||
| PlugWindowId = int(optarg) | |||
|
|
|||
| main(show_jobs) | |||
| from gi.repository import GLib | ||
| gi.require_version('Gtk', '3.0') | ||
| from gi.repository import Gtk | ||
| import avahi |
There was a problem hiding this comment.
Some distros currently do not ship Avahi Python module - can you catch the exception, show the error dialog if someone clicks on "Discover Services" about "Missing Avahi module - we could not discover mDNS services." and return back to the main window?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes my work of GSOC 2024.
I have added a feature in system config printer, where all available IPP services will be listed to the user. Also the web interface is also accessible using buttons.