-
Notifications
You must be signed in to change notification settings - Fork 14
Implement new sprite groups #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
spacek531
wants to merge
9
commits into
OpenRCT2:master
Choose a base branch
from
spacek531:refactor/sprite-groups
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For future reference: |
Gymnasiast
approved these changes
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the principle, we added those sprite groups to OpenRCT2 itself long ago and they’ve proven to be quite useful.
eb764aa to
a0fa5f2
Compare
cdf259c to
e6edf17
Compare
|
This is updated to improve things and include the new dive loop angles (not yet tested). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #26
Adding my sprite groups refactor to this tool. The general mode of operation is when activating or deactivating simple sprite groups, the
legacy_group_implicationsenables additional sprite groups based on what is currently enabled, or disables sprite groups if their constituents are not enabled. After the implication phase, the new sprite groups are enabled or disabled based onlegacy_group_mapand the default precision insprite_group_metadata. If the user switches from full to simple mode, the disable-enable code is run again, to prevent the project state from being different than what the options say.Todo: