front: ui-core input tooltip status messages #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wadjetz
force-pushed
the
ebe/front-input-tooltip-status-messages
branch
3 times, most recently
from
0abfc23 to
7932979
Compare
Wadjetz
force-pushed
the
ebe/front-input-tooltip-status-messages
branch
4 times, most recently
from
6d6a95e to
8129064
Compare
Wadjetz
force-pushed
the
ebe/front-input-tooltip-status-messages
branch
from
8129064 to
bb7bba0
Compare
SharglutDev
reviewed
Dec 20, 2024
| background-color: theme('colors.error.5'); | ||
| opacity: 1; | ||
| padding: 8px 12px; | ||
| min-height: 64px; |
There was a problem hiding this comment.
Not sure we need this ? If the message takes only one line maybe it doesn't have to be that high.
@thibautsailly is working on a mockup to define this case (hopefully should be up today)
8 tasks
Wadjetz
force-pushed
the
ebe/front-input-tooltip-status-messages
branch
from
1cca9a0 to
dd76afd
Compare
SharglutDev
reviewed
Dec 20, 2024
Wadjetz
force-pushed
the
ebe/front-input-tooltip-status-messages
branch
3 times, most recently
from
c7454b3 to
9c26754
Compare
4 tasks
SharglutDev
reviewed
Dec 20, 2024
Signed-off-by: Egor Berezovskiy <[email protected]>
Signed-off-by: Egor Berezovskiy <[email protected]>
Signed-off-by: Egor Berezovskiy <[email protected]>
Signed-off-by: Egor Berezovskiy <[email protected]>
Signed-off-by: Egor Berezovskiy <[email protected]>
Wadjetz
force-pushed
the
ebe/front-input-tooltip-status-messages
branch
from
e35c449 to
108ff18
Compare
Signed-off-by: Egor Berezovskiy <[email protected]>
Signed-off-by: Egor Berezovskiy <[email protected]>
Signed-off-by: Egor Berezovskiy <[email protected]>
|
Lgtm, except the last comment where we need @thibautsailly 's mockup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #770