This repository was archived by the owner on Aug 5, 2025. It is now read-only.
front: ui-core input tooltip status messages#776
Merged
Conversation
Wadjetz
force-pushed
the
ebe/front-input-tooltip-status-messages
branch
3 times, most recently
from
0abfc23 to
7932979
Compare
Wadjetz
force-pushed
the
ebe/front-input-tooltip-status-messages
branch
4 times, most recently
from
6d6a95e to
8129064
Compare
Wadjetz
force-pushed
the
ebe/front-input-tooltip-status-messages
branch
from
8129064 to
bb7bba0
Compare
SharglutDev
reviewed
Dec 20, 2024
8 tasks
Wadjetz
force-pushed
the
ebe/front-input-tooltip-status-messages
branch
from
1cca9a0 to
dd76afd
Compare
SharglutDev
reviewed
Dec 20, 2024
Wadjetz
force-pushed
the
ebe/front-input-tooltip-status-messages
branch
3 times, most recently
from
c7454b3 to
9c26754
Compare
4 tasks
SharglutDev
reviewed
Dec 20, 2024
Wadjetz
force-pushed
the
ebe/front-input-tooltip-status-messages
branch
from
e35c449 to
108ff18
Compare
Contributor
|
Lgtm, except the last comment where we need @thibautsailly 's mockup |
Contributor
|
Sorry, I haven't been able to finish this before the holidays. The Sketch library "OSRD Web" is updated with the requested informations. 
|
Wadjetz
force-pushed
the
ebe/front-input-tooltip-status-messages
branch
4 times, most recently
from
4db6300 to
00a1b02
Compare
SharglutDev
reviewed
Jan 3, 2025
Wadjetz
force-pushed
the
ebe/front-input-tooltip-status-messages
branch
2 times, most recently
from
af5853a to
bc4b6a8
Compare
SharglutDev
reviewed
Jan 3, 2025
Contributor
SharglutDev
left a comment
SharglutDev
left a comment
There was a problem hiding this comment.
Lgtm except one last comment :)
Contributor
|
Note We should keep in mind for your implementation PR what we want to do if the info tooltip is displayed and the user changes the value of the related input |
Wadjetz
force-pushed
the
ebe/front-input-tooltip-status-messages
branch
from
3a36082 to
5fdd821
Compare
SharglutDev
approved these changes
Jan 3, 2025
Contributor
SharglutDev
left a comment
SharglutDev
left a comment
There was a problem hiding this comment.
Lgtm and tested, great job !
Wadjetz
force-pushed
the
ebe/front-input-tooltip-status-messages
branch
from
5fdd821 to
db4623b
Compare
Signed-off-by: Egor Berezovskiy <egor@berezify.fr>
Wadjetz
force-pushed
the
ebe/front-input-tooltip-status-messages
branch
from
db4623b to
e547c6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #770