front: add route e2e test for operational studies

OpenRailAssociation · Jul 24, 2024 · ffd2df3 · ffd2df3
1 parent cb05924
commit ffd2df3
Show file tree

Hide file tree

Showing 16 changed files with 572 additions and 191 deletions.
diff --git a/front/src/common/BootstrapSNCF/NavBarSNCF.tsx b/front/src/common/BootstrapSNCF/NavBarSNCF.tsx
@@ -87,7 +87,7 @@ const LegacyNavBarSNCF = ({ appName, logo = getLogo() }: Props) => {
                 <span className="mr-2">
                   {i18n.language && getUnicodeFlagIcon(language2flag(i18n.language))}
                 </span>
-                {t(`language.${i18n.language}`)}
+                <span data-testid="language-info">{t(`language.${i18n.language}`)} </span>
               </button>,
               <button
                 data-testid="user-settings-btn"

diff --git a/front/src/modules/pathfinding/components/Itinerary/DisplayItinerary/v2/DestinationV2.tsx b/front/src/modules/pathfinding/components/Itinerary/DisplayItinerary/v2/DestinationV2.tsx
@@ -26,7 +26,7 @@ const DestinationV2 = ({ zoomToFeaturePoint }: DestinationProps) => {
         <span className="text-warning mr-2">
           <IoFlag />
         </span>
-        {t('noDestinationChosen')}
+        <span data-testid="no-destination-chosen-text">{t('noDestinationChosen')}</span>
       </>
     );
 
@@ -42,13 +42,14 @@ const DestinationV2 = ({ zoomToFeaturePoint }: DestinationProps) => {
           tabIndex={0}
           className="flex-grow-1"
         >
-          <strong className="mr-1 text-nowrap">
+          <strong data-testid="destination-op-info" className="mr-1 text-nowrap">
             {/* If destination doesn't have name, we know that it has been added by click on map and has a track property */}
             {destination?.name ||
               (destination && 'track' in destination && destination.track.split('-')[0])}
           </strong>
         </div>
         <button
+          data-testid="delete-destination-button"
           className="btn btn-sm btn-only-icon btn-white ml-auto"
           type="button"
           onClick={() => {

diff --git a/front/src/modules/pathfinding/components/Itinerary/DisplayItinerary/v2/OriginV2.tsx b/front/src/modules/pathfinding/components/Itinerary/DisplayItinerary/v2/OriginV2.tsx
@@ -56,7 +56,7 @@ const OriginV2 = ({ zoomToFeaturePoint }: OriginProps) => {
       role="button"
       tabIndex={0}
     >
-      <strong className="mr-1 text-nowrap">
+      <strong data-testid="origin-op-info" className="mr-1 text-nowrap">
         {/* If origin doesn't have name, we know that it has been added by click on map and has a track property */}
         {origin?.name || (origin && 'track' in origin && origin.track.split('-')[0])}
       </strong>
@@ -87,7 +87,7 @@ const OriginV2 = ({ zoomToFeaturePoint }: OriginProps) => {
         <span className="text-success mr-2">
           <RiMapPin2Fill />
         </span>
-        {t('noOriginChosen')}
+        <span data-testid="no-origin-chosen-text">{t('noOriginChosen')}</span>
       </>
     );
 
@@ -99,6 +99,7 @@ const OriginV2 = ({ zoomToFeaturePoint }: OriginProps) => {
         </span>
         <span className="flex-grow-1">{originPointName}</span>
         <button
+          data-testid="delete-origin-button"
           className="btn btn-sm btn-only-icon btn-white"
           type="button"
           onClick={() => {

diff --git a/front/src/modules/pathfinding/components/Itinerary/DisplayItinerary/v2/ViasV2.tsx b/front/src/modules/pathfinding/components/Itinerary/DisplayItinerary/v2/ViasV2.tsx
@@ -43,6 +43,7 @@ const ViasV2 = ({ zoomToFeaturePoint, shouldManageStopDuration }: DisplayViasV2P
               >
                 {(providedDraggable) => (
                   <div
+                    data-testid="dropped-via-info"
                     ref={providedDraggable.innerRef}
                     {...providedDraggable.draggableProps}
                     {...providedDraggable.dragHandleProps}
@@ -59,12 +60,14 @@ const ViasV2 = ({ zoomToFeaturePoint, shouldManageStopDuration }: DisplayViasV2P
                         tabIndex={0}
                       >
                         <small className="font-weight-bold text-muted mr-1">{index + 1}</small>
-                        <small className="mr-1 text-nowrap">
+                        <small data-testid="via-dropped-name" className="mr-1 text-nowrap">
                           {`${via.name || `KM ${via.positionOnPath && (Math.round(via.positionOnPath) / 1000000).toFixed(3)}`}`}
                         </small>
-                        {via.ch && <small>{via.ch}</small>}
+                        {via.ch && <small data-testid="via-dropped-ch">{via.ch}</small>}
                         {'uic' in via && (
-                          <small className="text-muted ml-3">{formatUicToCi(via.uic)}</small>
+                          <small data-testid="via-dropped-uic" className="text-muted ml-3">
+                            {formatUicToCi(via.uic)}
+                          </small>
                         )}
                       </div>
                       {shouldManageStopDuration && (
@@ -75,6 +78,7 @@ const ViasV2 = ({ zoomToFeaturePoint, shouldManageStopDuration }: DisplayViasV2P
                         />
                       )}
                       <button
+                        data-testid="delete-via-button"
                         className="btn btn-sm btn-only-icon btn-white ml-auto"
                         type="button"
                         onClick={() => dispatch(deleteViaV2(index))}

diff --git a/front/src/modules/pathfinding/components/Itinerary/ItineraryV2.tsx b/front/src/modules/pathfinding/components/Itinerary/ItineraryV2.tsx
@@ -115,6 +115,7 @@ const ItineraryV2 = ({
         <div className="d-flex flex-row flex-wrap">
           {pathProperties && pathProperties.suggestedOperationalPoints && (
             <button
+              data-testid="add-waypoints-button"
               className="col my-1 text-white btn bg-info btn-sm"
               type="button"
               onClick={() =>
@@ -125,12 +126,18 @@ const ItineraryV2 = ({
               <Plus />
             </button>
           )}
-          <button className="col ml-1 my-1 btn bg-warning btn-sm" type="button" onClick={inverseOD}>
+          <button
+            data-testid="reverse-itinerary-button"
+            className="col ml-1 my-1 btn bg-warning btn-sm"
+            type="button"
+            onClick={inverseOD}
+          >
             <span className="mr-1">{t('inverseOD')}</span>
             <ArrowSwitch />
           </button>
           <Tipped mode="right">
             <button
+              data-testid="delete-itinerary-button"
               type="button"
               className="ml-1 mt-1 btn-danger btn btn-sm"
               aria-label={t('deleteRoute')}
@@ -152,7 +159,9 @@ const ItineraryV2 = ({
                 shouldManageStopDuration={shouldManageStopDuration}
               />
             ) : (
-              <small className="ml-4">{t('noPlaceChosen')}</small>
+              <small data-testid="no-waypoint-chosen-text" className="ml-4">
+                {t('noPlaceChosen')}
+              </small>
             )}
           </div>
           <DestinationV2 zoomToFeaturePoint={zoomToFeaturePoint} />

diff --git a/front/src/modules/pathfinding/components/Itinerary/ModalSuggestedVias.tsx b/front/src/modules/pathfinding/components/Itinerary/ModalSuggestedVias.tsx
@@ -63,10 +63,14 @@ const ModalSuggestedVias = ({ suggestedVias }: ModalSuggestedViasProps) => {
         {op.uic && <small className="suggested-via-uic text-muted">{formatUicToCi(op.uic)}</small>}
         <div className="ml-auto">
           {op.positionOnPath && (
-            <small className="mr-2">{`KM ${(Math.round(op.positionOnPath) / 1000000).toFixed(3)}`}</small>
+            <small
+              data-testid="suggested-via-distance"
+              className="mr-2"
+            >{`KM ${(Math.round(op.positionOnPath) / 1000000).toFixed(3)}`}</small>
           )}
           {!isInVias ? (
             <button
+              data-testid="suggested-via-add-button"
               className="btn btn-sm btn-only-icon"
               type="button"
               aria-label={t('addVia')}
@@ -77,6 +81,7 @@ const ModalSuggestedVias = ({ suggestedVias }: ModalSuggestedViasProps) => {
             </button>
           ) : (
             <button
+              data-testid="suggested-via-delete-button"
               className="btn btn-sm btn-only-icon"
               type="button"
               aria-label={t('removeVia')}

diff --git a/front/src/modules/pathfinding/components/Pathfinding/PathfindingV2.tsx b/front/src/modules/pathfinding/components/Pathfinding/PathfindingV2.tsx
@@ -78,6 +78,7 @@ const Pathfinding = ({ pathProperties, setPathProperties }: PathfindingProps) =>
 
       {!pathProperties && isPathFindingActive ? (
         <div
+          data-testid="pathfinding-no-state"
           className={cx('content pathfinding-none', { 'mt-2': infra && infra.state !== 'CACHED' })}
         >
           {t('pathfindingNoState')}
@@ -103,7 +104,7 @@ const Pathfinding = ({ pathProperties, setPathProperties }: PathfindingProps) =>
               <span className="lead">
                 <Alert />
               </span>
-              <span className="flex-grow-1">
+              <span data-testid="missing-params-info" className="flex-grow-1">
                 {t('pathfindingMissingParams', { missingElements })}
               </span>
             </div>

diff --git a/front/tests/005-operational-studies.spec.ts b/front/tests/005-operational-studies.spec.ts
@@ -1,6 +1,3 @@
-import fs from 'fs';
-import path from 'path';
-
 import { test, expect } from '@playwright/test';
 import { v4 as uuidv4 } from 'uuid';
 
@@ -18,18 +15,11 @@ let study: Study;
 let scenario: Scenario;
 let rollingStock: RollingStock;
 
-const rollingstockPath = path.resolve(
-  __dirname,
-  '../tests/assets/rollingStock/thermal-electric_rolling_stock.json'
-);
-const rollingStockJson = JSON.parse(fs.readFileSync(rollingstockPath, 'utf8'));
-const thermalElectricRollingStockName = 'thermal-electric_rolling_stock';
 test.beforeAll(async () => {
   smallInfra = (await getInfra()) as Infra;
   project = await getProject();
   study = await getStudy(project.id);
   rollingStock = await getRollingStock();
-  await findAndDeleteRollingStock(thermalElectricRollingStockName);
 });
 
 test.beforeEach(async () => {

diff --git a/front/tests/006-stdcm-page.spec.ts b/front/tests/006-stdcm-page.spec.ts
@@ -21,7 +21,7 @@ test.describe('STDCM page', () => {
     // TODO: DROP STDCMV1: remove this part
     const homePage = new HomePage(page);
     await homePage.goToHomePage();
-    await stdcmPage.toggleStdcmV1();
+    await homePage.toggleStdcmV1();
 
     await stdcmPage.navigateToPage();
     await expect(stdcmPage.scenarioExplorerModal).not.toBeVisible();

diff --git a/front/tests/007-op-rollingstock-tab.spec.ts b/front/tests/007-op-rollingstock-tab.spec.ts
@@ -51,6 +51,7 @@ test.describe('Verifying that all elements in the rolling stock tab are loaded c
     const operationalStudiesPage = new OperationalStudiesPage(page);
     const scenarioPage = new ScenarioPage(page);
     const rollingStockSelector = new RollingStockSelectorPage(page);
+
     // TODO: DROP TSV1: remove this part
     const homePage = new HomePage(page);
     await homePage.goToHomePage();
@@ -65,7 +66,7 @@ test.describe('Verifying that all elements in the rolling stock tab are loaded c
     await scenarioPage.checkInfraLoaded();
 
     // Click on add train button
-    await operationalStudiesPage.clickOnAddScenarioTrainBtn();
+    await operationalStudiesPage.clickOnAddTrainBtn();
 
     // Verify the presence of warnings in Rolling Stock and Route Tab
     await operationalStudiesPage.verifyTabWarningPresence();
@@ -100,6 +101,7 @@ test.describe('Verifying that all elements in the rolling stock tab are loaded c
     const operationalStudiesPage = new OperationalStudiesPage(page);
     const scenarioPage = new ScenarioPage(page);
     const rollingStockSelector = new RollingStockSelectorPage(page);
+
     // TODO: DROP TSV1: remove this part
     const homePage = new HomePage(page);
     await homePage.goToHomePage();
@@ -114,7 +116,7 @@ test.describe('Verifying that all elements in the rolling stock tab are loaded c
     await scenarioPage.checkInfraLoaded();
 
     // Click on add train button
-    await operationalStudiesPage.clickOnAddScenarioTrainBtn();
+    await operationalStudiesPage.clickOnAddTrainBtn();
 
     // Open Rolling Stock Selector, search for the added train, and select it
     await operationalStudiesPage.openEmptyRollingStockSelector();