Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix scenario selection button in scenario card #7405

Merged

Conversation

RomainValls
Copy link
Contributor

closes #7312

@RomainValls RomainValls requested a review from a team as a code owner May 13, 2024 15:15
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 29.44%. Comparing base (ca3ae5a) to head (189e7c8).
Report is 1 commits behind head on dev.

Files Patch % Lines
...t/src/modules/scenario/components/ScenarioCard.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7405      +/-   ##
============================================
- Coverage     29.45%   29.44%   -0.01%     
  Complexity     2016     2016              
============================================
  Files          1162     1162              
  Lines        143491   143491              
  Branches       2809     2809              
============================================
- Hits          42264    42258       -6     
- Misses        99573    99579       +6     
  Partials       1654     1654              
Flag Coverage Δ
core 76.29% <ø> (ø)
editoast 72.31% <ø> (-0.03%) ⬇️
front 9.83% <0.00%> (ø)
gateway 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM :)

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix :) Lgtm

@SharglutDev SharglutDev added this pull request to the merge queue May 15, 2024
Merged via the queue into dev with commit 2ab7394 May 15, 2024
17 checks passed
@SharglutDev SharglutDev deleted the rvs/front-fix-scenario-selection-button-in-scenario-card branch May 15, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scenario selection button is grey on gray background
5 participants