-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix train on map (ts v2) #7773
Conversation
077a8d7
to
f3679a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice refacto ! Not tested.
front/src/modules/simulationResult/components/SimulationResultsMapV2.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under review
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7773 +/- ##
============================================
- Coverage 28.33% 28.27% -0.06%
Complexity 2075 2075
============================================
Files 1270 1273 +3
Lines 155784 156068 +284
Branches 3076 3079 +3
============================================
- Hits 44139 44136 -3
- Misses 109812 110096 +284
- Partials 1833 1836 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
80cd712
to
487c0ba
Compare
front/src/applications/operationalStudies/views/v2/SimulationResultsV2.tsx
Outdated
Show resolved
Hide resolved
Simulation is going backward now |
a7f2cce
to
ac678a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Good job !
ac678a6
to
0354953
Compare
fix #7578