Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix train on map (ts v2) #7773

Merged
merged 1 commit into from
Jul 5, 2024
Merged

front: fix train on map (ts v2) #7773

merged 1 commit into from
Jul 5, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Jun 18, 2024

fix #7578

@clarani clarani marked this pull request as ready for review June 20, 2024 16:51
@clarani clarani requested a review from a team as a code owner June 20, 2024 16:51
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice refacto ! Not tested.

Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under review

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 2.65700% with 403 lines in your changes missing coverage. Please review.

Project coverage is 28.27%. Comparing base (8a9e3ea) to head (0354953).
Report is 1 commits behind head on dev.

Files Patch % Lines
...c/common/Map/components/TrainOnMap/getTrainBody.ts 0.00% 133 Missing and 1 partial ⚠️
...rc/common/Map/components/TrainOnMap/TrainOnMap.tsx 0.00% 119 Missing and 1 partial ⚠️
...lationResult/components/SimulationResultsMapV2.tsx 0.00% 59 Missing ⚠️
...lationResultsMap/getSelectedTrainHoverPositions.ts 0.00% 38 Missing and 1 partial ⚠️
...t/components/SpeedSpaceChart/SpeedSpaceChartV2.tsx 0.00% 12 Missing ⚠️
...perationalStudies/views/v2/SimulationResultsV2.tsx 0.00% 10 Missing ⚠️
...mponents/SpaceCurvesSlopes/SpaceCurvesSlopesV2.tsx 0.00% 10 Missing ⚠️
...odules/simulationResult/components/TimeButtons.tsx 0.00% 8 Missing ⚠️
front/src/utils/physics.ts 69.23% 4 Missing ⚠️
...onents/SimulationResultsMap/TrainHoverPosition.tsx 0.00% 1 Missing and 1 partial ⚠️
... and 4 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7773      +/-   ##
============================================
- Coverage     28.33%   28.27%   -0.06%     
  Complexity     2075     2075              
============================================
  Files          1270     1273       +3     
  Lines        155784   156068     +284     
  Branches       3076     3079       +3     
============================================
- Hits          44139    44136       -3     
- Misses       109812   110096     +284     
- Partials       1833     1836       +3     
Flag Coverage Δ
core 75.03% <ø> (ø)
editoast 70.98% <ø> (-0.04%) ⬇️
front 9.93% <2.65%> (-0.02%) ⬇️
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni-7578-fix-train-on-map branch from 80cd712 to 487c0ba Compare July 1, 2024 16:29
@anisometropie
Copy link
Contributor

Simulation is going backward now
https://github.com/OpenRailAssociation/osrd/assets/24652545/28b7f95e-8100-4a18-9876-b18548a6f89a

@clarani clarani force-pushed the cni-7578-fix-train-on-map branch 2 times, most recently from a7f2cce to ac678a6 Compare July 3, 2024 15:16
@clarani clarani requested a review from kmer2016 July 3, 2024 15:19
Copy link
Contributor

@SarahBellaha SarahBellaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work 💪

Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Good job !

@clarani clarani force-pushed the cni-7578-fix-train-on-map branch from ac678a6 to 0354953 Compare July 5, 2024 15:01
@clarani clarani enabled auto-merge July 5, 2024 15:02
@clarani clarani added this pull request to the merge queue Jul 5, 2024
Merged via the queue into dev with commit b6df80a Jul 5, 2024
17 checks passed
@clarani clarani deleted the cni-7578-fix-train-on-map branch July 5, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSv2: Train on simulation map is gone
7 participants