Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: implement results in the new interface for one simulation #7815

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

Akctarus
Copy link
Contributor

@Akctarus Akctarus commented Jun 21, 2024

closes #7018

Here is the sketch :

Capture d’écran 2024-07-05 à 14 49 09

@Akctarus Akctarus force-pushed the tmn/front/stdcm/stdcmV2-results branch from 2d17bc2 to 906b058 Compare June 21, 2024 17:19
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0.28329% with 352 lines in your changes missing coverage. Please review.

Project coverage is 28.07%. Comparing base (bea61b1) to head (82d9730).

Files Patch % Lines
...cmV2/components/StdcmResults/StdcmResultsTable.tsx 0.00% 148 Missing and 1 partial ⚠️
...s/stdcmV2/components/StdcmResults/StdcmResults.tsx 0.00% 95 Missing and 1 partial ⚠️
...tions/stdcm/components/SimulationReportSheetV2.tsx 0.00% 24 Missing ⚠️
...rc/applications/stdcmV2/components/StdcmConfig.tsx 0.00% 15 Missing ⚠️
front/src/utils/date.ts 6.25% 15 Missing ⚠️
...nt/src/applications/stdcm/views/StdcmResultsV2.tsx 0.00% 13 Missing and 1 partial ⚠️
...ont/src/applications/stdcmV2/views/StdcmViewV2.tsx 0.00% 14 Missing ⚠️
front/src/applications/stdcm/utils.ts 0.00% 10 Missing and 1 partial ⚠️
front/src/applications/stdcm/hooks/useStdcm.ts 0.00% 8 Missing ⚠️
...lications/stdcmV2/components/StdcmResults/index.ts 0.00% 2 Missing and 1 partial ⚠️
... and 1 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7815      +/-   ##
============================================
- Coverage     28.12%   28.07%   -0.06%     
  Complexity     2075     2075              
============================================
  Files          1285     1288       +3     
  Lines        157442   157689     +247     
  Branches       3117     3120       +3     
============================================
- Hits          44279    44266      -13     
- Misses       111290   111547     +257     
- Partials       1873     1876       +3     
Flag Coverage Δ
core 75.03% <ø> (ø)
editoast 70.80% <ø> (-0.05%) ⬇️
front 9.94% <0.28%> (-0.03%) ⬇️
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akctarus Akctarus force-pushed the tmn/front/stdcm/stdcmV2-results branch 3 times, most recently from 0f8cc53 to 027c61d Compare June 25, 2024 13:43
@Akctarus Akctarus marked this pull request as ready for review June 25, 2024 13:43
@Akctarus Akctarus requested a review from a team as a code owner June 25, 2024 13:43
@Akctarus Akctarus self-assigned this Jun 25, 2024
@Akctarus Akctarus requested review from kmer2016, SarahBellaha, SharglutDev and Math-R and removed request for SharglutDev June 25, 2024 13:44
@Akctarus Akctarus force-pushed the tmn/front/stdcm/stdcmV2-results branch 4 times, most recently from 9ec851e to 6b2003c Compare June 27, 2024 10:03
@Akctarus Akctarus changed the title Tmn/front/stdcm/stdcm v2 results front: implement stdcm results for the new interface Jul 3, 2024
@Akctarus Akctarus force-pushed the tmn/front/stdcm/stdcmV2-results branch 5 times, most recently from 653ea6b to 4df9568 Compare July 5, 2024 12:41
@Akctarus Akctarus changed the title front: implement stdcm results for the new interface front: implement results in the new interface for one simulation Jul 5, 2024
@Akctarus Akctarus requested a review from Caracol3 July 5, 2024 12:45
@Akctarus Akctarus force-pushed the tmn/front/stdcm/stdcmV2-results branch 5 times, most recently from 2a27438 to c7a3bf5 Compare July 8, 2024 08:35
@Akctarus Akctarus removed the request for review from Math-R July 8, 2024 18:59
@clarani clarani self-assigned this Jul 9, 2024
front/src/applications/stdcmV2/views/StdcmViewV2.tsx Outdated Show resolved Hide resolved
front/src/applications/stdcmV2/views/StdcmViewV2.tsx Outdated Show resolved Hide resolved
front/src/applications/stdcmV2/views/StdcmViewV2.tsx Outdated Show resolved Hide resolved
front/src/applications/stdcmV2/views/StdcmViewV2.tsx Outdated Show resolved Hide resolved
front/public/locales/en/stdcm-simulation-report-sheet.json Outdated Show resolved Hide resolved
@clarani clarani removed their assignment Jul 9, 2024
@Akctarus Akctarus requested review from clarani and emersion and removed request for Caracol3 July 9, 2024 12:46
front/public/locales/en/stdcm-simulation-report-sheet.json Outdated Show resolved Hide resolved
front/src/applications/stdcm/hooks/useStdcm.ts Outdated Show resolved Hide resolved
front/src/applications/stdcm/hooks/useStdcm.ts Outdated Show resolved Hide resolved
front/src/applications/stdcm/hooks/useStdcm.ts Outdated Show resolved Hide resolved
front/src/applications/stdcm/hooks/useStdcm.ts Outdated Show resolved Hide resolved
front/src/applications/stdcm/types.ts Outdated Show resolved Hide resolved
front/src/applications/stdcm/types.ts Outdated Show resolved Hide resolved
front/src/applications/stdcm/utils.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also move the files you have added for stdcmRestults in a new folder like this: stdcmV2/components/StdcmResults ?
And you can also add an index, so in the view, when you import StdcmResults, you won't have import StdcmResults from '../components/StdcmResults/StdcmResults';. For the import, you can have a look in modules/RollingStock/components/RollingStockEditor/index.ts ;)

front/src/applications/stdcmV2/views/StdcmViewV2.tsx Outdated Show resolved Hide resolved
front/src/applications/stdcmV2/views/StdcmViewV2.tsx Outdated Show resolved Hide resolved
front/src/applications/stdcmV2/views/StdcmViewV2.tsx Outdated Show resolved Hide resolved
front/src/applications/stdcmV2/components/StdcmResults.tsx Outdated Show resolved Hide resolved
front/src/utils/date.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good for me, only 1 last thing, when I accept a simulation, and then launch a new one, the simulation is already selected

@Akctarus
Copy link
Contributor Author

Almost good for me, only 1 last thing, when I accept a simulation, and then launch a new one, the simulation is already selected

Nice catch ! I've added a useEffect to manage it

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested ! Nice PR, thanks ✅

@Akctarus Akctarus force-pushed the tmn/front/stdcm/stdcmV2-results branch 2 times, most recently from 4b9979f to 4103e5d Compare July 11, 2024 08:17
@Akctarus Akctarus enabled auto-merge July 11, 2024 08:18
@Akctarus Akctarus force-pushed the tmn/front/stdcm/stdcmV2-results branch from ed49491 to 971888e Compare July 11, 2024 08:25
@Akctarus Akctarus removed the request for review from SarahBellaha July 11, 2024 08:27
add simulation table

add creation date in simuation results

reset selected simulation when new one is created

hide results when simulation is on pending

automatically format css file
@Akctarus Akctarus force-pushed the tmn/front/stdcm/stdcmV2-results branch from 9e6bcd5 to 82d9730 Compare July 11, 2024 08:38
@Akctarus Akctarus added this pull request to the merge queue Jul 11, 2024
Merged via the queue into dev with commit 98e9bfe Jul 11, 2024
17 checks passed
@Akctarus Akctarus deleted the tmn/front/stdcm/stdcmV2-results branch July 11, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement results section of STDCM UI
4 participants