front: implement results in the new interface for one simulation #7815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akctarus
force-pushed
the
tmn/front/stdcm/stdcmV2-results
branch
from
2d17bc2
to
906b058
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7815 +/- ##
============================================
- Coverage 28.12% 28.07% -0.06%
Complexity 2075 2075
============================================
Files 1285 1288 +3
Lines 157442 157689 +247
Branches 3117 3120 +3
============================================
- Hits 44279 44266 -13
- Misses 111290 111547 +257
- Partials 1873 1876 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Akctarus
force-pushed
the
tmn/front/stdcm/stdcmV2-results
branch
3 times, most recently
from
0f8cc53
to
027c61d
Compare
Akctarus
requested review from
kmer2016,
SarahBellaha,
SharglutDev and
Math-R
and removed request for
SharglutDev
Akctarus
force-pushed
the
tmn/front/stdcm/stdcmV2-results
branch
4 times, most recently
from
9ec851e
to
6b2003c
Compare
Akctarus
changed the title
Akctarus
force-pushed
the
tmn/front/stdcm/stdcmV2-results
branch
5 times, most recently
from
653ea6b
to
4df9568
Compare
Akctarus
changed the title
Akctarus
force-pushed
the
tmn/front/stdcm/stdcmV2-results
branch
5 times, most recently
from
2a27438
to
c7a3bf5
Compare
clarani
requested changes
Jul 9, 2024
front/src/applications/stdcmV2/components/StdcmTableResults.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/stdcmV2/components/StdcmTableResults.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/stdcmV2/components/StdcmTableResults.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/stdcmV2/components/StdcmTableResults.tsx
Outdated
Show resolved
Hide resolved
emersion
reviewed
Jul 9, 2024
emersion
reviewed
Jul 9, 2024
emersion
reviewed
Jul 9, 2024
emersion
reviewed
Jul 9, 2024
Akctarus
requested review from
clarani and
emersion
and removed request for
Caracol3
clarani
reviewed
Jul 10, 2024
front/src/applications/stdcm/components/SimulationReportSheetV2.tsx
Outdated
Show resolved
Hide resolved
clarani
reviewed
Jul 10, 2024
There was a problem hiding this comment.
Can you also move the files you have added for stdcmRestults in a new folder like this: stdcmV2/components/StdcmResults ?
And you can also add an index, so in the view, when you import StdcmResults, you won't have import StdcmResults from '../components/StdcmResults/StdcmResults';. For the import, you can have a look in modules/RollingStock/components/RollingStockEditor/index.ts ;)
clarani
reviewed
Jul 10, 2024
clarani
reviewed
Jul 10, 2024
Nice catch ! I've added a useEffect to manage it |
clarani
approved these changes
Jul 11, 2024
Akctarus
force-pushed
the
tmn/front/stdcm/stdcmV2-results
branch
2 times, most recently
from
4b9979f
to
4103e5d
Compare
emersion
reviewed
Jul 11, 2024
Akctarus
force-pushed
the
tmn/front/stdcm/stdcmV2-results
branch
from
ed49491
to
971888e
Compare
clarani
approved these changes
Jul 11, 2024
add simulation table add creation date in simuation results reset selected simulation when new one is created hide results when simulation is on pending automatically format css file
Akctarus
force-pushed
the
tmn/front/stdcm/stdcmV2-results
branch
from
9e6bcd5
to
82d9730
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7018
Here is the sketch :