Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: add e2e tests search and filter rolling stock #7887

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

Maymanaf
Copy link
Contributor

@Maymanaf Maymanaf commented Jun 28, 2024

The locked RS filter wasn't added in this test : Can't add a locked train for now to the list of the existing rolling stock
( To be determined later)

Closes : #7826

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.06%. Comparing base (e65899e) to head (84491f5).
Report is 1 commits behind head on dev.

Files Patch % Lines
...onents/RollingStockSelector/SearchRollingStock.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7887      +/-   ##
============================================
- Coverage     28.06%   28.06%   -0.01%     
  Complexity     2075     2075              
============================================
  Files          1289     1289              
  Lines        157764   157764              
  Branches       3121     3121              
============================================
- Hits          44281    44275       -6     
- Misses       111606   111612       +6     
  Partials       1877     1877              
Flag Coverage Δ
core 75.03% <ø> (ø)
editoast 70.78% <ø> (-0.03%) ⬇️
front 9.94% <0.00%> (ø)
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Maymanaf Maymanaf force-pushed the aba/e2e-search-rolling-stock-test branch from 09be17f to 3b63c39 Compare July 1, 2024 11:42
@Maymanaf Maymanaf force-pushed the aba/e2e-search-rolling-stock-test branch 4 times, most recently from ec84144 to 57dd6d0 Compare July 5, 2024 14:32
@Maymanaf Maymanaf force-pushed the aba/e2e-search-rolling-stock-test branch 2 times, most recently from 012ddb5 to 4cda861 Compare July 5, 2024 15:06
@Maymanaf Maymanaf marked this pull request as ready for review July 5, 2024 15:35
@Maymanaf Maymanaf requested a review from a team as a code owner July 5, 2024 15:35
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work thank you !!!
I haven't tested it yet, i continue the review

Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, just a few comments

front/tests/assets/scenario-utlis.ts Outdated Show resolved Hide resolved
front/tests/assets/scenario-utlis.ts Outdated Show resolved Hide resolved
@Maymanaf Maymanaf force-pushed the aba/e2e-search-rolling-stock-test branch from 4cda861 to 3ffd41a Compare July 10, 2024 09:45
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@Caracol3 Caracol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one letter missing in a fonction

front/tests/009-rollingstock-editor.spec.ts Outdated Show resolved Hide resolved
front/tests/009-rollingstock-editor.spec.ts Outdated Show resolved Hide resolved
front/tests/pages/rolling-stock-selector-page.ts Outdated Show resolved Hide resolved
@Maymanaf Maymanaf force-pushed the aba/e2e-search-rolling-stock-test branch from 3ffd41a to 6f1739d Compare July 10, 2024 16:36
Copy link

@Caracol3 Caracol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Maymanaf Maymanaf requested a review from kmer2016 July 12, 2024 08:08
front/tests/008-allowances.spec.ts Outdated Show resolved Hide resolved
front/tests/009-rollingstock-editor.spec.ts Outdated Show resolved Hide resolved
@Maymanaf Maymanaf force-pushed the aba/e2e-search-rolling-stock-test branch from 6f1739d to cbbac52 Compare July 12, 2024 14:52
@Maymanaf Maymanaf force-pushed the aba/e2e-search-rolling-stock-test branch from cbbac52 to 84491f5 Compare July 15, 2024 08:13
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Maymanaf Maymanaf enabled auto-merge July 15, 2024 09:11
@Maymanaf Maymanaf added this pull request to the merge queue Jul 15, 2024
Merged via the queue into dev with commit 65e7f5b Jul 15, 2024
20 checks passed
@Maymanaf Maymanaf deleted the aba/e2e-search-rolling-stock-test branch July 15, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front : front: add e2e test filtering and searching for a rolling stock
5 participants