-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: add e2e tests search and filter rolling stock #7887
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7887 +/- ##
============================================
- Coverage 28.06% 28.06% -0.01%
Complexity 2075 2075
============================================
Files 1289 1289
Lines 157764 157764
Branches 3121 3121
============================================
- Hits 44281 44275 -6
- Misses 111606 111612 +6
Partials 1877 1877
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
09be17f
to
3b63c39
Compare
ec84144
to
57dd6d0
Compare
012ddb5
to
4cda861
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work thank you !!!
I haven't tested it yet, i continue the review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, just a few comments
4cda861
to
3ffd41a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one letter missing in a fonction
3ffd41a
to
6f1739d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
6f1739d
to
cbbac52
Compare
cbbac52
to
84491f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
The locked RS filter wasn't added in this test : Can't add a locked train for now to the list of the existing rolling stock
( To be determined later)
Closes : #7826