Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codegen filter to ModelV2 (maybe) #7898

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

leovalais
Copy link
Contributor

Doesn't seem to help with compilation times, not sure if it's worth keeping the option, TBD

@leovalais leovalais force-pushed the lva/modelv2-selective-impls branch from 590c43f to 19a2ddb Compare July 16, 2024 20:48
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.49%. Comparing base (f2d6885) to head (19a2ddb).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #7898       +/-   ##
=============================================
+ Coverage     28.07%   87.49%   +59.41%     
=============================================
  Files          1289       31     -1258     
  Lines        157794     1535   -156259     
  Branches       3121        0     -3121     
=============================================
- Hits          44301     1343    -42958     
+ Misses       111616      192   -111424     
+ Partials       1877        0     -1877     
Flag Coverage Δ
core ?
editoast ?
front ?
gateway ?
railjson_generator 87.49% <ø> (ø)
tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants