Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: add checks for input size in the scenario modal #7920

Merged

Conversation

theocrsb
Copy link
Contributor

@theocrsb theocrsb commented Jul 2, 2024

close #5935

@theocrsb theocrsb requested a review from a team as a code owner July 2, 2024 13:31
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 96 lines in your changes missing coverage. Please review.

Project coverage is 28.39%. Comparing base (c61b95f) to head (40ef040).

Files Patch % Lines
front/src/modules/project/utils.ts 0.00% 18 Missing and 1 partial ⚠️
...dules/project/components/AddOrEditProjectModal.tsx 0.00% 18 Missing ⚠️
front/src/modules/study/utils.ts 0.00% 17 Missing ⚠️
...c/modules/study/components/AddOrEditStudyModal.tsx 0.00% 16 Missing ⚠️
...les/scenario/components/AddOrEditScenarioModal.tsx 0.00% 13 Missing ⚠️
front/src/modules/scenario/utils.ts 0.00% 12 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7920      +/-   ##
============================================
- Coverage     28.42%   28.39%   -0.03%     
  Complexity     2059     2059              
============================================
  Files          1264     1266       +2     
  Lines        155100   155174      +74     
  Branches       3053     3055       +2     
============================================
- Hits          44082    44060      -22     
- Misses       109197   109291      +94     
- Partials       1821     1823       +2     
Flag Coverage Δ
core 75.00% <ø> (ø)
editoast 71.56% <ø> (-0.08%) ⬇️
front 9.98% <0.00%> (-0.01%) ⬇️
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job :)
I left a comment on project, but you can do the same for study and scenario

@theocrsb theocrsb force-pushed the tce/front/trainschedule/bug/error-message-input-too-long branch from 5304436 to adcfd8f Compare July 4, 2024 08:10
@theocrsb
Copy link
Contributor Author

theocrsb commented Jul 4, 2024

Nice job :) I left a comment on project, but you can do the same for study and scenario

Thank you for your feedback !

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost perfect, can you just rename the functions checkFields => checkProjectFields, checkScenarioFields, checkStudyFields ? Otherwise we have 3 functions checkFields which are exported, it's not very practical

@theocrsb theocrsb force-pushed the tce/front/trainschedule/bug/error-message-input-too-long branch from adcfd8f to 40ef040 Compare July 4, 2024 08:43
@theocrsb
Copy link
Contributor Author

theocrsb commented Jul 4, 2024

Almost perfect, can you just rename the functions checkFields => checkProjectFields, checkScenarioFields, checkStudyFields ? Otherwise we have 3 functions checkFields which are exported, it's not very practical

Of course it's done

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ tested

@theocrsb theocrsb added this pull request to the merge queue Jul 8, 2024
Merged via the queue into dev with commit 36dd06a Jul 8, 2024
17 checks passed
@theocrsb theocrsb deleted the tce/front/trainschedule/bug/error-message-input-too-long branch July 8, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: no specific error message when input is too long
3 participants