Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: refactor layers get records and app health #7939

Merged
merged 2 commits into from
Jul 15, 2024
Merged

editoast: refactor layers get records and app health #7939

merged 2 commits into from
Jul 15, 2024

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Jul 4, 2024 •
edited
Loading

part of #7135

@Wadjetz Wadjetz added the area:editoast Work on Editoast Service label Jul 4, 2024
@Wadjetz Wadjetz self-assigned this Jul 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 48.21429% with 29 lines in your changes missing coverage. Please review.

Project coverage is 28.06%. Comparing base (e65899e) to head (140f113).

Files Patch % Lines
editoast/src/modelsv2/layers/geo_json_and_data.rs 14.81% 23 Missing ⚠️
editoast/src/views/layers.rs 0.00% 3 Missing ⚠️
editoast/src/views/mod.rs 82.35% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #7939      +/-   ##
============================================
- Coverage     28.06%   28.06%   -0.01%     
  Complexity     2075     2075              
============================================
  Files          1289     1289              
  Lines        157764   157797      +33     
  Branches       3121     3121              
============================================
+ Hits          44281    44284       +3     
- Misses       111606   111636      +30     
  Partials       1877     1877
Flag Coverage Δ
core 75.03% <ø> (ø)
editoast 70.73% <48.21%> (-0.07%) ⬇️
front 9.94% <ø> (ø)
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wadjetz Wadjetz force-pushed the ebe/editoast-refactor-layers-get-records-and-app-health branch from ebdfe01 to 55626e3 Compare July 4, 2024 08:25
@Wadjetz Wadjetz marked this pull request as ready for review July 4, 2024 08:59
@Wadjetz Wadjetz requested a review from a team as a code owner July 4, 2024 08:59
leovalais
leovalais requested changes Jul 4, 2024
View reviewed changes
editoast/editoast_models/src/app_health.rs Outdated Show resolved Hide resolved
editoast/src/views/layers/mvt_utils.rs Outdated Show resolved Hide resolved
@Wadjetz Wadjetz force-pushed the ebe/editoast-refactor-layers-get-records-and-app-health branch from 55626e3 to c163934 Compare July 4, 2024 15:01
@Wadjetz Wadjetz force-pushed the ebe/editoast-refactor-layers-get-records-and-app-health branch 2 times, most recently from 06e2bfd to cff3951 Compare July 5, 2024 09:26
@Wadjetz Wadjetz requested a review from leovalais July 5, 2024 13:18
leovalais
leovalais requested changes Jul 5, 2024
View reviewed changes
editoast/editoast_models/src/db_connection_pool.rs Outdated Show resolved Hide resolved
editoast/editoast_models/src/error.rs Outdated Show resolved Hide resolved
editoast/src/models/layers/mod.rs Outdated Show resolved Hide resolved
editoast/src/models/layers/mod.rs Outdated Show resolved Hide resolved
editoast/src/models/mod.rs Outdated Show resolved Hide resolved
editoast/src/views/mod.rs Outdated Show resolved Hide resolved
@Wadjetz Wadjetz force-pushed the ebe/editoast-refactor-layers-get-records-and-app-health branch from cff3951 to d9d5a0a Compare July 8, 2024 09:05
@Wadjetz Wadjetz requested a review from leovalais July 8, 2024 12:22
@Wadjetz Wadjetz force-pushed the ebe/editoast-refactor-layers-get-records-and-app-health branch 3 times, most recently from d59cddf to 88e6cd3 Compare July 9, 2024 09:41
@Wadjetz Wadjetz requested a review from a team as a code owner July 9, 2024 09:41
leovalais
leovalais requested changes Jul 10, 2024
View reviewed changes
editoast/src/views/mod.rs Outdated Show resolved Hide resolved
@Wadjetz Wadjetz force-pushed the ebe/editoast-refactor-layers-get-records-and-app-health branch 2 times, most recently from 61dc94a to b683d2a Compare July 11, 2024 08:42
@Wadjetz Wadjetz requested a review from leovalais July 11, 2024 08:44
@Wadjetz Wadjetz force-pushed the ebe/editoast-refactor-layers-get-records-and-app-health branch from b683d2a to dc160bf Compare July 11, 2024 09:22
@Wadjetz Wadjetz force-pushed the ebe/editoast-refactor-layers-get-records-and-app-health branch from dc160bf to ccc7608 Compare July 11, 2024 10:52
leovalais
leovalais approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, thanks! 🚀

@Wadjetz Wadjetz force-pushed the ebe/editoast-refactor-layers-get-records-and-app-health branch from 0689f03 to e3d630c Compare July 11, 2024 13:44
@Wadjetz Wadjetz enabled auto-merge July 11, 2024 13:46
@Wadjetz Wadjetz disabled auto-merge July 11, 2024 13:57
@Wadjetz Wadjetz force-pushed the ebe/editoast-refactor-layers-get-records-and-app-health branch from e3d630c to aa03600 Compare July 11, 2024 14:03
@Wadjetz Wadjetz enabled auto-merge July 11, 2024 14:32
@Wadjetz Wadjetz force-pushed the ebe/editoast-refactor-layers-get-records-and-app-health branch from aa03600 to ff33b7d Compare July 12, 2024 08:20
@Wadjetz Wadjetz requested a review from flomonster July 15, 2024 07:56
@Wadjetz Wadjetz disabled auto-merge July 15, 2024 07:56
@Wadjetz Wadjetz requested a review from kmer2016 July 15, 2024 07:57
@Wadjetz Wadjetz force-pushed the ebe/editoast-refactor-layers-get-records-and-app-health branch from ff33b7d to 140f113 Compare July 15, 2024 07:57
clarani
clarani approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not tested ✅

@Wadjetz Wadjetz added this pull request to the merge queue Jul 15, 2024
Merged via the queue into dev with commit 64f0491 Jul 15, 2024
20 checks passed
@Wadjetz Wadjetz deleted the ebe/editoast-refactor-layers-get-records-and-app-health branch July 15, 2024 09:04
@woshilapin woshilapin mentioned this pull request Jul 16, 2024
Draft
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leovalais leovalais leovalais approved these changes

@woshilapin woshilapin woshilapin approved these changes

@clarani clarani clarani approved these changes

@flomonster flomonster Awaiting requested review from flomonster

@kmer2016 kmer2016 Awaiting requested review from kmer2016

Assignees

@Wadjetz Wadjetz

Labels
area:editoast Work on Editoast Service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Wadjetz @codecov-commenter @woshilapin @flomonster @leovalais @clarani