Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: implement macro editor OP import #7940

Draft
wants to merge 13 commits into
base: dev
Choose a base branch
from
Draft

Conversation

emersion
Copy link
Member

@emersion emersion commented Jul 4, 2024

Import operational points into NGE.

Closes #7737
Closes #7739
Depends on #8006 (in other words, please ignore the first few commits, they belong to that other PR)

TODO:

  • Handle non-UIC path items
  • Prettify node coords
  • Pagination
  • Handle OP secondary code?
  • Adjust coords for large number of nodes (try with France infra test cases, e.g. Paris-Lyon-Grenoble)
  • Find a more suitable location for the new files?
  • Check if rtk-query requests need to be unsubscribed
  • The import process should only kick in when the macro tab is selected
  • Passthrough UICs/trigrams that we don't find in infra

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 688 lines in your changes missing coverage. Please review.

Project coverage is 27.95%. Comparing base (65e7f5b) to head (cb29af7).
Report is 7 commits behind head on dev.

Files Patch % Lines
...perationalStudies/components/MacroEditor/import.ts 0.00% 334 Missing and 1 partial ⚠️
...operationalStudies/components/MacroEditor/types.ts 0.00% 151 Missing and 1 partial ⚠️
...cations/operationalStudies/views/v2/ScenarioV2.tsx 0.00% 130 Missing ⚠️
.../operationalStudies/components/MacroEditor/NGE.tsx 0.00% 69 Missing and 1 partial ⚠️
front/src/common/Tabs.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7940      +/-   ##
============================================
- Coverage     28.07%   27.95%   -0.12%     
  Complexity     2075     2075              
============================================
  Files          1289     1292       +3     
  Lines        157792   158428     +636     
  Branches       3121     3124       +3     
============================================
- Hits          44294    44289       -5     
- Misses       111621   112259     +638     
- Partials       1877     1880       +3     
Flag Coverage Δ
core 75.03% <ø> (ø)
editoast 70.75% <ø> (-0.03%) ⬇️
front 9.88% <0.00%> (-0.06%) ⬇️
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emersion emersion force-pushed the emersion/nge-import branch 6 times, most recently from c87330e to e033faa Compare July 4, 2024 11:53
@emersion emersion force-pushed the emersion/nge-import branch 2 times, most recently from 431f85d to 1824bb0 Compare July 11, 2024 13:44
@emersion emersion force-pushed the emersion/nge-import branch 4 times, most recently from 857bbb8 to 08d0301 Compare July 16, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert train schedules/runs from OSRD to NGE, basic version Convert infrastructure from OSRD to NGE
4 participants