Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add telemetry to core requests #7958

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

woshilapin
Copy link
Contributor

@woshilapin woshilapin commented Jul 5, 2024

We don't have any information about how long it takes for each request to core. This telemetry should give us some information about it.

@woshilapin woshilapin requested a review from a team as a code owner July 5, 2024 10:17
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.34%. Comparing base (725b89a) to head (5989d4b).
Report is 1 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7958      +/-   ##
============================================
- Coverage     28.35%   28.34%   -0.01%     
  Complexity     2075     2075              
============================================
  Files          1270     1270              
  Lines        155669   155626      -43     
  Branches       3076     3076              
============================================
- Hits          44135    44112      -23     
+ Misses       109701   109681      -20     
  Partials       1833     1833              
Flag Coverage Δ
core 75.02% <ø> (ø)
editoast 71.30% <100.00%> (+0.02%) ⬆️
front 9.95% <ø> (ø)
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@woshilapin woshilapin force-pushed the wsl/feat/editoast/core-telemetry branch from d057c76 to 5989d4b Compare July 5, 2024 12:02
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (Not tested)

@woshilapin woshilapin added this pull request to the merge queue Jul 8, 2024
Merged via the queue into dev with commit 8c9c749 Jul 8, 2024
17 checks passed
@woshilapin woshilapin deleted the wsl/feat/editoast/core-telemetry branch July 8, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants