-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: highlight train not keep timetable #7959
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7959 +/- ##
============================================
- Coverage 28.25% 28.24% -0.02%
Complexity 2075 2075
============================================
Files 1276 1276
Lines 156197 156265 +68
Branches 3084 3084
============================================
- Hits 44140 44132 -8
- Misses 110216 110292 +76
Partials 1841 1841
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, LGTM, left few comments :)
front/src/modules/trainschedule/components/TimetableV2/hooks.ts
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/TimetableV2/hooks.ts
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/TimetableV2/TimetableTrainCardV2.tsx
Outdated
Show resolved
Hide resolved
c72c73e
to
7cfd3eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
front/src/modules/trainschedule/components/TimetableV2/hooks.ts
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/TimetableV2/TimetableTrainCardV2.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/TimetableV2/hooks.ts
Outdated
Show resolved
Hide resolved
3dca36c
to
6c2c8a5
Compare
front/src/modules/trainschedule/components/TimetableV2/hooks.ts
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/TimetableV2/hooks.ts
Outdated
Show resolved
Hide resolved
95eee70
to
50c6ac8
Compare
front/src/modules/trainschedule/components/ManageTrainSchedule/helpers/formatMargin.ts
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/TimetableV2/hooks.ts
Outdated
Show resolved
Hide resolved
50c6ac8
to
d9e156c
Compare
d9e156c
to
10efaa6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
For the moment I have just highlighted the trains which do not keep their timetable because the data on the back side is a simple boolean
closes #7738