Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: highlight train not keep timetable #7959

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

theocrsb
Copy link
Contributor

@theocrsb theocrsb commented Jul 5, 2024

For the moment I have just highlighted the trains which do not keep their timetable because the data on the back side is a simple boolean

closes #7738

@theocrsb theocrsb requested review from clarani and Akctarus July 5, 2024 12:02
@theocrsb theocrsb requested a review from a team as a code owner July 5, 2024 12:02
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 75 lines in your changes missing coverage. Please review.

Project coverage is 28.24%. Comparing base (c390cb4) to head (10efaa6).

Files Patch % Lines
...ainschedule/components/TimetableV2/FilterPanel.tsx 0.00% 28 Missing ⚠️
...ules/trainschedule/components/TimetableV2/hooks.ts 0.00% 21 Missing ⚠️
...le/components/TimetableV2/TimetableTrainCardV2.tsx 0.00% 15 Missing ⚠️
...hedule/components/TimetableV2/TimetableToolbar.tsx 0.00% 11 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7959      +/-   ##
============================================
- Coverage     28.25%   28.24%   -0.02%     
  Complexity     2075     2075              
============================================
  Files          1276     1276              
  Lines        156197   156265      +68     
  Branches       3084     3084              
============================================
- Hits          44140    44132       -8     
- Misses       110216   110292      +76     
  Partials       1841     1841              
Flag Coverage Δ
core 75.03% <ø> (ø)
editoast 71.00% <ø> (-0.03%) ⬇️
front 9.91% <0.00%> (-0.01%) ⬇️
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM, left few comments :)

@theocrsb theocrsb force-pushed the tce/front/trainschedule/highlight-train branch from c72c73e to 7cfd3eb Compare July 5, 2024 14:47
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small bugs:

  • the invalid trains are not filtered when I chose to display only the trains which honored their waypoints or not
  • the train invalid has the yellow band

image

@theocrsb theocrsb force-pushed the tce/front/trainschedule/highlight-train branch 2 times, most recently from 3dca36c to 6c2c8a5 Compare July 8, 2024 21:44
@theocrsb theocrsb force-pushed the tce/front/trainschedule/highlight-train branch 3 times, most recently from 95eee70 to 50c6ac8 Compare July 9, 2024 13:01
@theocrsb theocrsb force-pushed the tce/front/trainschedule/highlight-train branch from 50c6ac8 to d9e156c Compare July 9, 2024 17:23
@theocrsb theocrsb force-pushed the tce/front/trainschedule/highlight-train branch from d9e156c to 10efaa6 Compare July 9, 2024 17:27
@theocrsb theocrsb requested a review from clarani July 9, 2024 17:32
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@theocrsb theocrsb added this pull request to the merge queue Jul 10, 2024
Merged via the queue into dev with commit 8035ab8 Jul 10, 2024
17 checks passed
@theocrsb theocrsb deleted the tce/front/trainschedule/highlight-train branch July 10, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: highlight trains that do not keep to their timetables
4 participants