Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xmas logo 🎅 #7962

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Add xmas logo 🎅 #7962

merged 1 commit into from
Jul 8, 2024

Conversation

flomonster
Copy link
Contributor

Winter is coming.

@flomonster flomonster requested a review from a team as a code owner July 5, 2024 13:11
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 51 lines in your changes missing coverage. Please review.

Project coverage is 28.27%. Comparing base (b5e1c9d) to head (940952f).
Report is 9 commits behind head on dev.

Files Patch % Lines
front/src/utils/logo.ts 0.00% 30 Missing and 1 partial ⚠️
front/src/applications/operationalStudies/Home.tsx 0.00% 6 Missing ⚠️
front/src/applications/editor/Home.tsx 0.00% 2 Missing ⚠️
front/src/applications/referenceMap/Home.tsx 0.00% 2 Missing ⚠️
front/src/applications/rollingStockEditor/Home.tsx 0.00% 2 Missing ⚠️
front/src/applications/stdcm/Home.tsx 0.00% 2 Missing ⚠️
front/src/common/BootstrapSNCF/NavBarSNCF.tsx 0.00% 2 Missing ⚠️
...common/ReleaseInformations/ReleaseInformations.tsx 0.00% 2 Missing ⚠️
front/src/main/home.jsx 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7962      +/-   ##
============================================
- Coverage     28.35%   28.27%   -0.08%     
  Complexity     2075     2075              
============================================
  Files          1270     1274       +4     
  Lines        155669   156126     +457     
  Branches       3076     3082       +6     
============================================
+ Hits          44137    44147      +10     
- Misses       109699   110140     +441     
- Partials       1833     1839       +6     
Flag Coverage Δ
core 75.03% <ø> (+<0.01%) ⬆️
editoast 71.01% <ø> (-0.28%) ⬇️
front 9.92% <0.00%> (-0.03%) ⬇️
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just missing the "save the planet" one and we should be good! 😝

front/src/main/home.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm !

@flomonster flomonster force-pushed the fam/xmas-logo branch 2 times, most recently from 7fee650 to 7b70748 Compare July 5, 2024 14:46
@flomonster flomonster enabled auto-merge July 5, 2024 14:46
@flomonster flomonster added this pull request to the merge queue Jul 8, 2024
Merged via the queue into dev with commit c9332df Jul 8, 2024
17 checks passed
@flomonster flomonster deleted the fam/xmas-logo branch July 8, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants