Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tce/trainschedule/bug image project #7963

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

theocrsb
Copy link
Contributor

@theocrsb theocrsb commented Jul 5, 2024

close #7267
close #7266

@theocrsb theocrsb self-assigned this Jul 5, 2024
@theocrsb theocrsb requested a review from a team as a code owner July 5, 2024 13:45
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 28.34%. Comparing base (0114e7c) to head (93bfbcc).
Report is 1 commits behind head on dev.

Files Patch % Lines
...onalStudies/components/Project/PictureUploader.tsx 0.00% 15 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7963      +/-   ##
============================================
- Coverage     28.34%   28.34%   -0.01%     
  Complexity     2075     2075              
============================================
  Files          1270     1270              
  Lines        155672   155679       +7     
  Branches       3076     3076              
============================================
- Hits          44133    44120      -13     
- Misses       109706   109726      +20     
  Partials       1833     1833              
Flag Coverage Δ
core 75.03% <ø> (+<0.01%) ⬆️
editoast 71.22% <ø> (-0.05%) ⬇️
front 9.95% <0.00%> (-0.01%) ⬇️
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SarahBellaha SarahBellaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

@SharglutDev SharglutDev added this pull request to the merge queue Jul 8, 2024
Merged via the queue into dev with commit ebb60e7 Jul 8, 2024
17 checks passed
@SharglutDev SharglutDev deleted the tce/trainschedule/bug-image-project branch July 8, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The cross "X" is displayed even no image is selected Wrong label for the image uploader in project
4 participants