editoast: train-simulation: return SimulationFailed on 500 from core #7971
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
core.fetch
returns an Error made from a 500 from core,train_simulation
returnsOk(SimulationResponse::SimulationFailed)
rather than anError
.This allows to still be able to call
train_schedule/simulation_summary
when one of the trains leads to an error in core (an assert error for example).I left other error status codes fail because they'll likely be transient, what do you think ?