Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front:add rolling stock selectos e2e test for operational studies #7974

Merged
merged 1 commit into from
Jul 22, 2024
Merged

front:add rolling stock selectos e2e test for operational studies #7974

merged 1 commit into from
Jul 22, 2024

Conversation

Maymanaf
Copy link
Contributor

@Maymanaf Maymanaf commented Jul 8, 2024 •
edited

Closes #7911

This PR contains minor changes to the naming of page objects.

@Maymanaf Maymanaf force-pushed the aba/e2e-operational-studie-rolling-stock branch 2 times, most recently from bd7a611 to 4cda861 Compare July 8, 2024 10:16
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2024 •
edited

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 28.10%. Comparing base (a3464b9) to head (05cf607).
Report is 29 commits behind head on dev.

Files Patch % Lines
...nents/RollingStockCard/RollingStockCardButtons.tsx 0.00% 5 Missing ⚠️
...nents/RollingStockSelector/RollingStockHelpers.tsx 0.00% 5 Missing ⚠️
...ents/RollingStockSelector/RollingStockSelector.tsx 0.00% 3 Missing ⚠️
...src/common/BootstrapSNCF/SwitchSNCF/SwitchSNCF.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #7974      +/-   ##
============================================
+ Coverage     28.06%   28.10%   +0.04%     
  Complexity     2081     2081              
============================================
  Files          1289     1289              
  Lines        157718   157780      +62     
  Branches       3114     3131      +17     
============================================
+ Hits          44256    44350      +94     
+ Misses       111587   111540      -47     
- Partials       1875     1890      +15
Flag Coverage Δ
core 75.11% <ø> (-0.09%) ⬇️
editoast 70.76% <ø> (-0.04%) ⬇️
front 9.98% <0.00%> (+0.08%) ⬆️
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 73.18% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Maymanaf Maymanaf force-pushed the aba/e2e-operational-studie-rolling-stock branch from ef0d050 to 41947c4 Compare July 8, 2024 10:47
@Maymanaf Maymanaf force-pushed the aba/e2e-operational-studie-rolling-stock branch 4 times, most recently from aa1c0a5 to a54ced6 Compare July 15, 2024 15:13
@Maymanaf Maymanaf marked this pull request as ready for review July 15, 2024 15:24
@Maymanaf Maymanaf requested a review from a team as a code owner July 15, 2024 15:24
@Maymanaf Maymanaf force-pushed the aba/e2e-operational-studie-rolling-stock branch from a54ced6 to ac45d26 Compare July 16, 2024 10:50
@Maymanaf Maymanaf force-pushed the aba/e2e-operational-studie-rolling-stock branch from ac45d26 to 8377be2 Compare July 16, 2024 11:49
theocrsb
theocrsb reviewed Jul 16, 2024
View reviewed changes
front/tests/pages/map-model.ts Outdated Show resolved Hide resolved
front/tests/pages/operationa-studies-page-model.ts Outdated Show resolved Hide resolved
front/tests/pages/rollingstock-editor-page-model.ts Outdated Show resolved Hide resolved
Akctarus
Akctarus reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM ! Good PR :)

There is no test 007, perhaps we should rename tests 008, 009 and 010?

@Maymanaf Maymanaf force-pushed the aba/e2e-operational-studie-rolling-stock branch 3 times, most recently from 46b55e2 to 2c21670 Compare July 16, 2024 14:04
@Maymanaf Maymanaf requested review from SharglutDev and removed request for achrafmohye and clarani July 17, 2024 09:27
@Maymanaf Maymanaf force-pushed the aba/e2e-operational-studie-rolling-stock branch 2 times, most recently from 1b989df to a60a60e Compare July 17, 2024 12:55
theocrsb
theocrsb approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Maymanaf Maymanaf force-pushed the aba/e2e-operational-studie-rolling-stock branch from a60a60e to 68843ab Compare July 17, 2024 13:02
@Maymanaf Maymanaf force-pushed the aba/e2e-operational-studie-rolling-stock branch 2 times, most recently from 7ca7f64 to c551de1 Compare July 17, 2024 13:22
SharglutDev
SharglutDev requested changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR ! I didn't have time to finish the review completely but here are the first comments

front/tests/pages/home-page-model.ts Show resolved Hide resolved
front/tests/pages/project-page-model.ts Show resolved Hide resolved
front/tests/pages/study-page-model.ts Show resolved Hide resolved
front/tests/pages/rolling-stock-selector-page.ts Outdated Show resolved Hide resolved
front/tests/pages/rolling-stock-selector-page.ts Outdated Show resolved Hide resolved
front/tests/007-operational-studies-tabs.spec.ts Outdated Show resolved Hide resolved
@Maymanaf Maymanaf force-pushed the aba/e2e-operational-studie-rolling-stock branch from c551de1 to ecc2faa Compare July 18, 2024 08:50
@Maymanaf Maymanaf force-pushed the aba/e2e-operational-studie-rolling-stock branch from ecc2faa to 05cf607 Compare July 18, 2024 15:13
SharglutDev
SharglutDev approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Couldn't test it as for me it fails each time it tries to click on the tsv2 switch (even though it works fine on the CI)

Capture d’écran 2024-07-18 à 17 48 47

@Maymanaf Maymanaf added this pull request to the merge queue Jul 22, 2024
@Maymanaf
Copy link
Contributor Author

Lgtm. Couldn't test it as for me it fails each time it tries to click on the tsv2 switch (even though it works fine on the CI)

Capture d’écran 2024-07-18 à 17 48 47

We retested multiple times, and it's working fine.
Changing the line of code to this.TSV2Switch.click({ force: true }); in home-page-model.ts may solve the issue if it occurs again.

Merged via the queue into dev with commit 773d136 Jul 22, 2024
20 checks passed
@Maymanaf Maymanaf deleted the aba/e2e-operational-studie-rolling-stock branch July 22, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akctarus Akctarus Akctarus approved these changes

@theocrsb theocrsb theocrsb approved these changes

@SharglutDev SharglutDev SharglutDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: add e2e tests operational studies - rolling stock selector
5 participants
@Maymanaf @codecov-commenter @Akctarus @theocrsb @SharglutDev