-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front:add rolling stock selectos e2e test for operational studies #7974
Conversation
bd7a611
to
4cda861
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7974 +/- ##
============================================
+ Coverage 28.06% 28.10% +0.04%
Complexity 2081 2081
============================================
Files 1289 1289
Lines 157718 157780 +62
Branches 3114 3131 +17
============================================
+ Hits 44256 44350 +94
+ Misses 111587 111540 -47
- Partials 1875 1890 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ef0d050
to
41947c4
Compare
aa1c0a5
to
a54ced6
Compare
a54ced6
to
ac45d26
Compare
ac45d26
to
8377be2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM ! Good PR :)
There is no test 007, perhaps we should rename tests 008, 009 and 010?
46b55e2
to
2c21670
Compare
1b989df
to
a60a60e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a60a60e
to
68843ab
Compare
7ca7f64
to
c551de1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR ! I didn't have time to finish the review completely but here are the first comments
c551de1
to
ecc2faa
Compare
ecc2faa
to
05cf607
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #7911
This PR contains minor changes to the naming of page objects.